You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ra...@apache.org on 2018/09/16 14:36:55 UTC
[cordova-cli] branch cross-spawn-test updated (3dae152 -> fbd1e16)
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a change to branch cross-spawn-test
in repository https://gitbox.apache.org/repos/asf/cordova-cli.git.
discard 3dae152 Remove flaky test for cross-spawn test setup
omit b18b99f Stub telemetry calls during all tests
add f8ed27c Stub telemetry calls during all tests (#327)
new fbd1e16 Remove flaky test for cross-spawn test setup
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (3dae152)
\
N -- N -- N refs/heads/cross-spawn-test (fbd1e16)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[cordova-cli] 01/01: Remove flaky test for cross-spawn test setup
Posted by ra...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a commit to branch cross-spawn-test
in repository https://gitbox.apache.org/repos/asf/cordova-cli.git
commit fbd1e16c3dc706c36a74e52e3073307698d242d1
Author: Raphael von der Grün <ra...@gmail.com>
AuthorDate: Sun Sep 16 13:15:28 2018 +0200
Remove flaky test for cross-spawn test setup
---
spec/cli.spec.js | 26 --------------------------
1 file changed, 26 deletions(-)
diff --git a/spec/cli.spec.js b/spec/cli.spec.js
index 172dd17..17269d2 100644
--- a/spec/cli.spec.js
+++ b/spec/cli.spec.js
@@ -290,32 +290,6 @@ describe('cordova cli', () => {
});
});
- it('Test#028 : opts-out if prompt times out AND it tracks opt-out', () => {
- // Remove any optOut settings that might have been saved
- // ... and force prompt to be shown
- telemetry.clear();
-
- // We override telemetry timeout here so we don't need to wait
- // 30 seconds. 0s is impossible with the current implementation.
- telemetry.timeoutInSecs = 0.01;
-
- // Don't display the prompt
- spyOn(process.stdout, 'write');
-
- telemetry.isOptedIn.and.callThrough();
- telemetry.showPrompt.and.callThrough();
- telemetry.hasUserOptedInOrOut.and.returnValue(false);
-
- return cli(['node', 'cordova', '--version']).then(() => {
- if (process.env.CI) {
- expect(telemetry.isOptedIn()).toBeTruthy();
- } else {
- expect(telemetry.isOptedIn()).toBeFalsy();
- }
- expect(telemetry.track).toHaveBeenCalledWith('telemetry', 'off', 'via-cli-prompt-choice', 'successful');
- });
- });
-
it("Test#029 : is NOT collected in CI environments and doesn't prompt", () => {
telemetry.isCI.and.returnValue(true);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org