You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "godfrey he (Jira)" <ji...@apache.org> on 2020/04/26 02:16:00 UTC

[jira] [Updated] (FLINK-17383) flink legacy planner should not use CollectionEnvironment any more

     [ https://issues.apache.org/jira/browse/FLINK-17383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

godfrey he updated FLINK-17383:
-------------------------------
    Description: 
As discussed in https://github.com/apache/flink/pull/11794,{{CollectionEnvironment}} is not a good practice, as it is not going through all the steps that a regular user program would go. We should change the tests to use {{LocalEnvironment}}. 

commit "Introduce CollectionPipelineExecutor for CollectionEnvironment ([c983ac9|https://github.com/apache/flink/commit/c983ac9c49b7b58394574efdde4f39e8d33a8582])"  should also be reverted at that moment.

  was:
As discussed in https://github.com/apache/flink/pull/11794,{{CollectionEnvironment}} is not a good practice, as it is not going through all the steps that a regular user program would go. We should change the tests to use {{LocalEnvironment}}. 

commit " Introduce CollectionPipelineExecutor for CollectionEnvironment ([c983ac9|https://github.com/apache/flink/commit/c983ac9c49b7b58394574efdde4f39e8d33a8582])"  should also be reverted at that mement.


> flink legacy planner should not use CollectionEnvironment any more
> ------------------------------------------------------------------
>
>                 Key: FLINK-17383
>                 URL: https://issues.apache.org/jira/browse/FLINK-17383
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Legacy Planner
>            Reporter: godfrey he
>            Priority: Major
>             Fix For: 1.11.0
>
>
> As discussed in https://github.com/apache/flink/pull/11794,{{CollectionEnvironment}} is not a good practice, as it is not going through all the steps that a regular user program would go. We should change the tests to use {{LocalEnvironment}}. 
> commit "Introduce CollectionPipelineExecutor for CollectionEnvironment ([c983ac9|https://github.com/apache/flink/commit/c983ac9c49b7b58394574efdde4f39e8d33a8582])"  should also be reverted at that moment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)