You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/11/12 22:34:42 UTC

[GitHub] [airflow] whynick1 commented on a change in pull request #6565: [AIRFLOW-5909] Enable mapping to BYTEs type to sql_to_gcs operator

whynick1 commented on a change in pull request #6565: [AIRFLOW-5909] Enable mapping to BYTEs type to sql_to_gcs operator
URL: https://github.com/apache/airflow/pull/6565#discussion_r345481746
 
 

 ##########
 File path: airflow/operators/sql_to_gcs.py
 ##########
 @@ -252,10 +252,36 @@ def _write_local_schema_file(self, cursor):
             contains the BigQuery schema fields in .json format.
         """
         schema = [self.field_to_bigquery(field) for field in cursor.description]
+        tmp_schema_file_handle = NamedTemporaryFile(delete=True)
 
 Review comment:
   Could you also update the block comment, regarding `self.schema` will be honored when provided, otherwise, use  schema read from sq.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services