You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by GitBox <gi...@apache.org> on 2022/11/08 20:58:20 UTC
[GitHub] [velocity-tools] arkanovicz commented on pull request #12: VELTOOLS-198
arkanovicz commented on PR #12:
URL: https://github.com/apache/velocity-tools/pull/12#issuecomment-1307816850
Thanks for identifying this issue.
On [this page](https://stackoverflow.com/questions/4387170/decimalformat-formatdouble-in-different-threads) someone had a measurement of ~23ms for the format instantiation. This is a figure which is highly dependent on the measurement conditions but still, it means that in terms of number of cycles its order of magnitude to be taken into consideration.
The thread-local paradigm is not optimal here since in a web context for instance, requests are rarely made by the same thread. I would rather use a pool, each thread taking a format instance from the pool and putting it back afterwards. Apache commons has plenty of ready-made pools for this use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: WARNING: Illegal reflective access
Posted by Michael Osipov <mi...@apache.org>.
Am 2022-11-09 um 09:39 schrieb Greg Huber:
> Hello,
>
> I see this in my compile on java 11.
>
>
> WARNING: An illegal reflective access operation has occurred WARNING:
> Illegal reflective access by
> org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl
> (file:~.m2/repository/org/apache/velocity/velocity-engine-core/2.3/velocity-engine-core-2.3.jar) to method com.sun.tools.javac.code.Symbol$MethodSymbol.getReturnType() WARNING: Please consider reporting this to the maintainers of org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release.
>
> I guess this is already known?
Please check JIRA and report with a reproducer.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
WARNING: Illegal reflective access
Posted by Greg Huber <gr...@gmail.com>.
Hello,
I see this in my compile on java 11.
WARNING: An illegal reflective access operation has occurred WARNING:
Illegal reflective access by
org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl
(file:~.m2/repository/org/apache/velocity/velocity-engine-core/2.3/velocity-engine-core-2.3.jar)
to method com.sun.tools.javac.code.Symbol$MethodSymbol.getReturnType()
WARNING: Please consider reporting this to the maintainers of
org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl
WARNING: Use --illegal-access=warn to enable warnings of further illegal
reflective access operations WARNING: All illegal access operations will
be denied in a future release.
I guess this is already known?
Cheers Greg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org