You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "michael-o (via GitHub)" <gi...@apache.org> on 2024/06/01 20:24:37 UTC
[PR] [MPIR-451] Rename "Dependency Information" to "Maven Coordinates" [maven-project-info-reports-plugin]
michael-o opened a new pull request, #67:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/67
This closes #67
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPIR) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MPIR-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MPIR-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPIR-451] Rename "Dependency Information" to "Maven Coordinates" [maven-project-info-reports-plugin]
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #67: [MPIR-451] Rename "Dependency Information" to "Maven Coordinates"
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPIR-451] Rename "Dependency Information" to "Maven Coordinates" [maven-project-info-reports-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #67:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/67#issuecomment-2143765024
Note from me: I agree with @elharo's sentiments that this goal is incorrently named. I lines up with the other dependency goals which are about the project's deps and not about this project being a dep somewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPIR-451] Rename "Dependency Information" to "Maven Coordinates" [maven-project-info-reports-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #67:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/67#discussion_r1623401367
##########
src/site/apt/index.apt.vm:
##########
@@ -44,8 +44,8 @@ ${project.name}
* {{{./dependency-convergence-mojo.html}project-info-reports:dependency-convergence}} is used to generate the
Project Dependency Convergence report for (reactor) builds.
- * {{{./dependency-info-mojo.html}project-info-reports:dependency-info}} is used to generate code snippets to
- be added to build tools.
+ * {{{./dependency-info-mojo.html}project-info-reports:dependency-info}} is used to generate code snippets
Review Comment:
This goes throughout all bulletpoints. I'd leave as is and do this in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPIR-451] Rename "Dependency Information" to "Maven Coordinates" [maven-project-info-reports-plugin]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #67:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/67#discussion_r1623397208
##########
src/main/resources/project-info-reports_fr.properties:
##########
@@ -117,8 +117,8 @@ report.dependency-convergence.stats.readyrelease.success = Succ\u00e8s
report.dependency-convergence.stats.snapshots = Nombre d'artefacts SNAPSHOT (NOS)\u202f:
report.dependency-convergence.stats.modules = Nombre de sous-projets\u202f:
report.dependency-convergence.title = R\u00e9action de la convergence des d\u00e9pendances
-report.dependency-info.name = Informations de d\u00e9pendance
-report.dependency-info.title = Informations de d\u00e9pendance
+report.dependency-info.name = Coordonnu00e9es de Maven
Review Comment:
I think you're missing a backslash before \u00e9 here and in the next line
##########
src/site/apt/index.apt.vm:
##########
@@ -79,6 +79,17 @@ ${project.name}
* {{{./summary-mojo.html}project-info-reports:summary}} is used to generate the Project Summary report.
+* Upcoming Incompatibility Notice
+
+ With the next major version (4.0) mojos and output filenames will change for consistency alignment
Review Comment:
period at end
##########
src/site/apt/index.apt.vm:
##########
@@ -44,8 +44,8 @@ ${project.name}
* {{{./dependency-convergence-mojo.html}project-info-reports:dependency-convergence}} is used to generate the
Project Dependency Convergence report for (reactor) builds.
- * {{{./dependency-info-mojo.html}project-info-reports:dependency-info}} is used to generate code snippets to
- be added to build tools.
+ * {{{./dependency-info-mojo.html}project-info-reports:dependency-info}} is used to generate code snippets
Review Comment:
is used to generate --> generates
##########
src/site/apt/index.apt.vm:
##########
@@ -79,6 +79,17 @@ ${project.name}
* {{{./summary-mojo.html}project-info-reports:summary}} is used to generate the Project Summary report.
+* Upcoming Incompatibility Notice
+
+ With the next major version (4.0) mojos and output filenames will change for consistency alignment
+ To make you aware of that, see the following table for the upcoming changes:
Review Comment:
Might drop "To make you aware of that,"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org