You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/01 13:59:38 UTC

[GitHub] [incubator-superset] villebro opened a new pull request #7963: Remove collation info from MSSQL column type

villebro opened a new pull request #7963: Remove collation info from MSSQL column type
URL: https://github.com/apache/incubator-superset/pull/7963
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   MSSQL columns can have lengthy types due to collations, for example `NVARCHAR(50) COLLATE SQL_LATIN1_GENERAL_CP1_CI_AS`, exceeding the 32 character limit in Superset. This PR copies logic from the MySQL spec which removes the unnecessary collation info.
   
   ### TEST PLAN
   Test locally
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: Fixes #7870
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @vitorbellini @syazwan0913

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org