You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/22 08:59:04 UTC

[GitHub] [shardingsphere] tuohai666 opened a new pull request #5753: #5452, fix syntax rule of SUBSTRING and CONVERT

tuohai666 opened a new pull request #5753:
URL: https://github.com/apache/shardingsphere/pull/5753


   Fixes #5452.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #5753: #5452, fix syntax rule of SUBSTRING and CONVERT

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #5753:
URL: https://github.com/apache/shardingsphere/pull/5753


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #5753: #5452, fix syntax rule of SUBSTRING and CONVERT

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #5753:
URL: https://github.com/apache/shardingsphere/pull/5753#issuecomment-632627481


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5753?src=pr&el=h1) Report
   > Merging [#5753](https://codecov.io/gh/apache/shardingsphere/pull/5753?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/df08f42a91ebac300edf755140d90584972d43eb&el=desc) will **decrease** coverage by `0.08%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5753/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5753?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5753      +/-   ##
   ============================================
   - Coverage     53.20%   53.11%   -0.09%     
   - Complexity      431      432       +1     
   ============================================
     Files          1168     1168              
     Lines         20572    20600      +28     
     Branches       3708     3715       +7     
   ============================================
   - Hits          10945    10942       -3     
   - Misses         8958     8989      +31     
     Partials        669      669              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5753?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...re/proxy/backend/schema/ShardingSphereSchemas.java](https://codecov.io/gh/apache/shardingsphere/pull/5753/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9zY2hlbWEvU2hhcmRpbmdTcGhlcmVTY2hlbWFzLmphdmE=) | `26.92% <0.00%> (-3.85%)` | `0.00% <0.00%> (ø%)` | |
   | [.../db/protocol/mysql/payload/MySQLPacketPayload.java](https://codecov.io/gh/apache/shardingsphere/pull/5753/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BheWxvYWQvTXlTUUxQYWNrZXRQYXlsb2FkLmphdmE=) | `93.39% <0.00%> (-3.67%)` | `0.00% <0.00%> (ø%)` | |
   | [...ava/org/apache/shardingsphere/proxy/Bootstrap.java](https://codecov.io/gh/apache/shardingsphere/pull/5753/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9Cb290c3RyYXAuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [.../shardingsphere/kernal/context/SchemaContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/5753/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUta2VybmFsL3NoYXJkaW5nc3BoZXJlLWtlcm5hbC1jb250ZXh0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9rZXJuYWwvY29udGV4dC9TY2hlbWFDb250ZXh0cy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...ere/proxy/backend/schema/ShardingSphereSchema.java](https://codecov.io/gh/apache/shardingsphere/pull/5753/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9zY2hlbWEvU2hhcmRpbmdTcGhlcmVTY2hlbWEuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...proxy/backend/executor/BackendExecutorContext.java](https://codecov.io/gh/apache/shardingsphere/pull/5753/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9leGVjdXRvci9CYWNrZW5kRXhlY3V0b3JDb250ZXh0LmphdmE=) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...xy/backend/text/admin/BroadcastBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/5753/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL0Jyb2FkY2FzdEJhY2tlbmRIYW5kbGVyLmphdmE=) | `85.71% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [.../column/value/MySQLBinlogProtocolValueFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5753/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9iaW5sb2cvcm93L2NvbHVtbi92YWx1ZS9NeVNRTEJpbmxvZ1Byb3RvY29sVmFsdWVGYWN0b3J5LmphdmE=) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...l/command/admin/initdb/MySQLComInitDbExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/5753/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2NvbW1hbmQvYWRtaW4vaW5pdGRiL015U1FMQ29tSW5pdERiRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...here/proxy/context/ShardingSphereProxyContext.java](https://codecov.io/gh/apache/shardingsphere/pull/5753/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9jb250ZXh0L1NoYXJkaW5nU3BoZXJlUHJveHlDb250ZXh0LmphdmE=) | | | |
   | ... and [3 more](https://codecov.io/gh/apache/shardingsphere/pull/5753/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5753?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5753?src=pr&el=footer). Last update [df08f42...c2a453e](https://codecov.io/gh/apache/shardingsphere/pull/5753?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org