You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by wilderrodrigues <gi...@git.apache.org> on 2015/06/25 08:06:07 UTC
[GitHub] cloudstack pull request: Using Profiler class, from the utils pack...
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/524
Using Profiler class, from the utils package, instead of System.currentTimeMillis()
Yesterday I found out that some methods' execution time are being measured based on System.currentTimeMillis() calls. We have a Profiler class, under the com.cloud.utils package, so I'm trying to make the use of that class consistent.
The PR is split in 2 commits: one for the formatting changes; and the other for applying the Profiler usage.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/schubergphilis/cloudstack fix/no_sys_timemillis_I
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/524.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #524
----
commit e0b27fe62c70582c8fdececd60840188d00c9f0c
Author: wilderrodrigues <wr...@schubergphilis.com>
Date: 2015-06-25T05:59:35Z
Formatting class ClusterManagerImpl
- Splitting format commit from fix commit.
commit 72e8b75622b7e74e34b159aa569c847b5e292c60
Author: wilderrodrigues <wr...@schubergphilis.com>
Date: 2015-06-25T06:01:51Z
Using Profiler class, from the utils package, instead of System.currentTimeMillis()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Using Profiler class, from the utils pack...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/524
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Using Profiler class, from the utils pack...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/524#issuecomment-115120064
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---