You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Tomás Fernández Löbbe <to...@gmail.com> on 2019/10/29 17:41:13 UTC

Re: [lucene-solr] branch master updated: SOLR-13783: fix failing tests due to NamedList.toString() change

Thanks Munendra,
sorry for the noise.

On Tue, Oct 29, 2019 at 1:06 AM <mu...@apache.org> wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> munendrasn pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
>      new b82b772  SOLR-13783: fix failing tests due to
> NamedList.toString() change
> b82b772 is described below
>
> commit b82b7725e110cd482c7a4372dc3b1a47eee2023a
> Author: Munendra S N <mu...@apache.org>
> AuthorDate: Tue Oct 29 13:35:31 2019 +0530
>
>     SOLR-13783: fix failing tests due to NamedList.toString() change
> ---
>  solr/core/src/test/org/apache/solr/core/TestBadConfig.java     |  2 +-
>  .../update/processor/UpdateRequestProcessorFactoryTest.java    | 10
> +++++-----
>  2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/solr/core/src/test/org/apache/solr/core/TestBadConfig.java
> b/solr/core/src/test/org/apache/solr/core/TestBadConfig.java
> index db04152..1dfad85 100644
> --- a/solr/core/src/test/org/apache/solr/core/TestBadConfig.java
> +++ b/solr/core/src/test/org/apache/solr/core/TestBadConfig.java
> @@ -82,7 +82,7 @@ public class TestBadConfig extends
> AbstractBadConfigTestBase {
>
>    public void testSchemaMutableButNotManaged() throws Exception {
>      assertConfigs("bad-solrconfig-schema-mutable-but-not-managed.xml",
> -                  "schema-minimal.xml", "Unexpected arg(s):
> {mutable=false,managedSchemaResourceName=schema.xml}");
> +                  "schema-minimal.xml", "Unexpected arg(s):
> {mutable=false, managedSchemaResourceName=schema.xml}");
>    }
>
>    public void testManagedSchemaCannotBeNamedSchemaDotXml() throws
> Exception {
> diff --git
> a/solr/core/src/test/org/apache/solr/update/processor/UpdateRequestProcessorFactoryTest.java
> b/solr/core/src/test/org/apache/solr/update/processor/UpdateRequestProcessorFactoryTest.java
> index 7d53b4f..66d612f 100644
> ---
> a/solr/core/src/test/org/apache/solr/update/processor/UpdateRequestProcessorFactoryTest.java
> +++
> b/solr/core/src/test/org/apache/solr/update/processor/UpdateRequestProcessorFactoryTest.java
> @@ -16,21 +16,21 @@
>   */
>  package org.apache.solr.update.processor;
>
> -import static
> org.apache.solr.update.processor.DistributingUpdateProcessorFactory.DISTRIB_UPDATE_PARAM;
> -
>  import java.lang.invoke.MethodHandles;
> -import java.util.Arrays;
>  import java.util.ArrayList;
> +import java.util.Arrays;
>  import java.util.List;
>
> +import org.apache.solr.SolrTestCaseJ4;
>  import org.apache.solr.common.params.ModifiableSolrParams;
>  import org.apache.solr.core.SolrCore;
>  import org.apache.solr.response.SolrQueryResponse;
> -import org.apache.solr.SolrTestCaseJ4;
>  import org.junit.BeforeClass;
>  import org.slf4j.Logger;
>  import org.slf4j.LoggerFactory;
>
> +import static
> org.apache.solr.update.processor.DistributingUpdateProcessorFactory.DISTRIB_UPDATE_PARAM;
> +
>  /**
>   *
>   */
> @@ -87,7 +87,7 @@ public class UpdateRequestProcessorFactoryTest extends
> SolrTestCaseJ4 {
>      assertEquals( custom, core.getUpdateProcessingChain( "custom" ) );
>
>      // Make sure the NamedListArgs got through ok
> -    assertEquals( "{name={n8=88,n9=99}}", link.args.toString() );
> +    assertEquals( "{name={n8=88, n9=99}}", link.args.toString() );
>    }
>
>    public void testUpdateDistribChainSkipping() throws Exception {
>
>