You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/07/16 23:09:12 UTC
[kudu-CR] [docs] fix typo in ntpq output description
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13871
Change subject: [docs] fix typo in ntpq output description
......................................................................
[docs] fix typo in ntpq output description
Change-Id: Ic32f65a75be39f9acd59008ab62fde5619f3b70c
---
M docs/troubleshooting.adoc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/13871/1
--
To view, visit http://gerrit.cloudera.org:8080/13871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic32f65a75be39f9acd59008ab62fde5619f3b70c
Gerrit-Change-Number: 13871
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [docs] fix typo in ntpq output description
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13871 )
Change subject: [docs] fix typo in ntpq output description
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic32f65a75be39f9acd59008ab62fde5619f3b70c
Gerrit-Change-Number: 13871
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 17 Jul 2019 00:11:51 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] fix typo in ntpq output description
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13871 )
Change subject: [docs] fix typo in ntpq output description
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13871/1/docs/troubleshooting.adoc
File docs/troubleshooting.adoc:
http://gerrit.cloudera.org:8080/#/c/13871/1/docs/troubleshooting.adoc@235
PS1, Line 235:
: TIP: Both `opeers` and `lpeers` may be helpful as `lpeers` lists refid and
: jitter, while `opeers` lists clock dispersion.
Nit: reorder so it's "Both opeers and lpeers...as opeers...and lpeers..." (i.e. the ordering of opeers/lpeers is the same in both halves of the sentence).
--
To view, visit http://gerrit.cloudera.org:8080/13871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic32f65a75be39f9acd59008ab62fde5619f3b70c
Gerrit-Change-Number: 13871
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 16 Jul 2019 23:14:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] fix typo in ntpq output description
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13871 )
Change subject: [docs] fix typo in ntpq output description
......................................................................
[docs] fix typo in ntpq output description
Change-Id: Ic32f65a75be39f9acd59008ab62fde5619f3b70c
Reviewed-on: http://gerrit.cloudera.org:8080/13871
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M docs/troubleshooting.adoc
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic32f65a75be39f9acd59008ab62fde5619f3b70c
Gerrit-Change-Number: 13871
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [docs] fix typo in ntpq output description
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13871 )
Change subject: [docs] fix typo in ntpq output description
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ic32f65a75be39f9acd59008ab62fde5619f3b70c
Gerrit-Change-Number: 13871
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [docs] fix typo in ntpq output description
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13871 )
Change subject: [docs] fix typo in ntpq output description
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13871/1/docs/troubleshooting.adoc
File docs/troubleshooting.adoc:
http://gerrit.cloudera.org:8080/#/c/13871/1/docs/troubleshooting.adoc@235
PS1, Line 235:
: TIP: Both `opeers` and `lpeers` may be helpful as `lpeers` lists refid and
: jitter, while `opeers` lists clock dispersion.
> Nit: reorder so it's "Both opeers and lpeers...as opeers...and lpeers..." (
Done. Now the order also matches the corresponding snippets above.
--
To view, visit http://gerrit.cloudera.org:8080/13871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic32f65a75be39f9acd59008ab62fde5619f3b70c
Gerrit-Change-Number: 13871
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 17 Jul 2019 00:08:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] fix typo in ntpq output description
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13871 )
Change subject: [docs] fix typo in ntpq output description
......................................................................
Patch Set 2: Verified+1
Unrelated failures:
* in case of TSAN builds due to known race at shutdown time
* in release build due to non-synced clock: Cannot initialize clock: Timed out waiting for clock sync: Error reading clock. Clock considered unsynchronized
--
To view, visit http://gerrit.cloudera.org:8080/13871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic32f65a75be39f9acd59008ab62fde5619f3b70c
Gerrit-Change-Number: 13871
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jul 2019 01:12:12 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] fix typo in ntpq output description
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13871
to look at the new patch set (#2).
Change subject: [docs] fix typo in ntpq output description
......................................................................
[docs] fix typo in ntpq output description
Change-Id: Ic32f65a75be39f9acd59008ab62fde5619f3b70c
---
M docs/troubleshooting.adoc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/13871/2
--
To view, visit http://gerrit.cloudera.org:8080/13871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic32f65a75be39f9acd59008ab62fde5619f3b70c
Gerrit-Change-Number: 13871
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)