[jira] [Resolved] (WW-3732) XWorkBasicConverter with BigDecimal; trim input as in extended class: DefaultTypeConverter

["Maurizio Cucchiara (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WW-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maurizio Cucchiara resolved WW-3732.
------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 2.3.16)
         Assignee: Maurizio Cucchiara
    
> XWorkBasicConverter with BigDecimal; trim input as in extended class: DefaultTypeConverter
> ------------------------------------------------------------------------------------------
>
>                 Key: WW-3732
>                 URL: https://issues.apache.org/jira/browse/WW-3732
>             Project: Struts 2
>          Issue Type: Bug
>            Reporter: Kevin Biesbrock
>            Assignee: Maurizio Cucchiara
>
> When a value for a parameter of type `BigDecimal` is converted by `XWorkBasicConverter` (this is default Struts2 behavior), a failure occurs when there is a space in the value. The parent to `XWorkBasicConverter`, `DefaultTypeConverter`, has a `stringValue` method that could could be used instead of immediately casting to a String, e.g., `new BigDecimal((String) value)`, which is what ultimately appears to cause a `NumberFormatException` to be thrown from the `BigDecimal` constructor when there is a space in the value.
> For example, in version 2.2.3.1, the following lines could be changed as indicated:
>   403: return new BigDecimal(stringValue(value, true));
>   405: return new BigInteger(stringValue(value, true));
>   408: String stringValue = stringValue(value, true);
>   414: String stringValue = stringValue(value, true);
> In fact, at the end of the doConvertToNumber method (where the previous lines reside), as a catch-all, the parameters are passed to the DefaultTypeConverter's `convertValue` method which calls the `bigDecValue` method which calls the `stringValue` method (when all the conditionals align).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira