You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by gn...@apache.org on 2026/10/22 09:48:52 UTC
(maven) branch feature/build-environment updated: remove noTransferProgress from BuildInvocation — will be subsumed by #13180 console mode configuration
This is an automated email from the ASF dual-hosted git repository.
gnodet pushed a commit to branch feature/build-environment
in repository https://gitbox.apache.org/repos/asf/maven.git
The following commit(s) were added to refs/heads/feature/build-environment by this push:
new be0118d7f4 remove noTransferProgress from BuildInvocation — will be subsumed by #13180 console mode configuration
be0118d7f4 is described below
commit be0118d7f49f7387db4fd6403d1d9f512ba4b049
Author: Guillaume Nodet <gn...@gmail.com>
AuthorDate: Thu Oct 22 09:28:49 2026 +0000
remove noTransferProgress from BuildInvocation — will be subsumed by #13180 console mode configuration
---
.../main/java/org/apache/maven/api/BuildInvocation.java | 9 +--------
.../org/apache/maven/cling/invoker/mvn/MavenInvoker.java | 5 ++---
.../maven/execution/DefaultMavenExecutionRequest.java | 14 --------------
.../org/apache/maven/execution/MavenExecutionRequest.java | 9 ---------
.../maven/internal/build/DefaultBuildInvocation.java | 3 ---
.../maven/internal/build/DefaultBuildInvocationTest.java | 13 -------------
6 files changed, 3 insertions(+), 50 deletions(-)
diff --git a/api/maven-api-core/src/main/java/org/apache/maven/api/BuildInvocation.java b/api/maven-api-core/src/main/java/org/apache/maven/api/BuildInvocation.java
index 6a819673e9..5350e72236 100644
--- a/api/maven-api-core/src/main/java/org/apache/maven/api/BuildInvocation.java
+++ b/api/maven-api-core/src/main/java/org/apache/maven/api/BuildInvocation.java
@@ -52,7 +52,7 @@
* <li>Offline mode ({@link #offline()}) and snapshot update policy
* ({@link #updateSnapshots()})</li>
* <li>Degree of concurrency ({@link #threads()})</li>
- * <li>Transfer-progress suppression ({@link #noTransferProgress()}) and batch mode ({@link #batchMode()})</li>
+ * <li>Batch mode ({@link #batchMode()})</li>
* </ul>
*
* <h2>What is not yet captured</h2>
@@ -191,13 +191,6 @@ public interface BuildInvocation {
*/
boolean updateSnapshots();
- /**
- * Whether transfer progress output was suppressed ({@code --no-transfer-progress} / {@code -ntp}).
- *
- * @return {@code true} if transfer progress was disabled
- */
- boolean noTransferProgress();
-
/**
* Whether the build was invoked in non-interactive (batch) mode ({@code --batch-mode} / {@code -B}).
* Equivalent to {@code !isInteractiveMode()} on {@code MavenExecutionRequest}.
diff --git a/impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvn/MavenInvoker.java b/impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvn/MavenInvoker.java
index 747032cc2d..03357c5f09 100644
--- a/impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvn/MavenInvoker.java
+++ b/impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvn/MavenInvoker.java
@@ -267,9 +267,8 @@ protected void populateRequest(MavenContext context, Lookup lookup, MavenExecuti
}
}
- boolean noTransferProgress = context.options().noTransferProgress().orElse(false);
- request.setNoTransferProgress(noTransferProgress);
- request.setTransferListener(determineTransferListener(context, noTransferProgress));
+ request.setTransferListener(determineTransferListener(
+ context, context.options().noTransferProgress().orElse(false)));
request.setExecutionListener(determineExecutionListener(context));
request.setResumeFrom(context.options().resumeFrom().orElse(null));
diff --git a/impl/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java b/impl/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
index 73e4762d3c..eedfe23016 100644
--- a/impl/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
+++ b/impl/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
@@ -64,8 +64,6 @@ public class DefaultMavenExecutionRequest implements MavenExecutionRequest {
private boolean interactiveMode = true;
- private boolean noTransferProgress = false;
-
private boolean cacheTransferError = false;
private boolean cacheNotFound = false;
@@ -182,7 +180,6 @@ public static MavenExecutionRequest copy(MavenExecutionRequest original) {
copy.setLocalRepositoryPath(original.getLocalRepositoryPath());
copy.setOffline(original.isOffline());
copy.setInteractiveMode(original.isInteractiveMode());
- copy.setNoTransferProgress(original.isNoTransferProgress());
copy.setCacheNotFound(original.isCacheNotFound());
copy.setCacheTransferError(original.isCacheTransferError());
copy.setIgnoreMissingArtifactDescriptor(original.isIgnoreMissingArtifactDescriptor());
@@ -330,17 +327,6 @@ public boolean isInteractiveMode() {
return interactiveMode;
}
- @Override
- public boolean isNoTransferProgress() {
- return noTransferProgress;
- }
-
- @Override
- public MavenExecutionRequest setNoTransferProgress(boolean noTransferProgress) {
- this.noTransferProgress = noTransferProgress;
- return this;
- }
-
@Override
public MavenExecutionRequest setActiveProfiles(List<String> activeProfiles) {
if (activeProfiles != null) {
diff --git a/impl/maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java b/impl/maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java
index 37ce870501..baf0080177 100644
--- a/impl/maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java
+++ b/impl/maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java
@@ -279,15 +279,6 @@ public interface MavenExecutionRequest {
boolean isInteractiveMode();
- // Transfer progress
- default MavenExecutionRequest setNoTransferProgress(boolean noTransferProgress) {
- return this;
- }
-
- default boolean isNoTransferProgress() {
- return false;
- }
-
// Offline
MavenExecutionRequest setOffline(boolean offline);
diff --git a/impl/maven-core/src/main/java/org/apache/maven/internal/build/DefaultBuildInvocation.java b/impl/maven-core/src/main/java/org/apache/maven/internal/build/DefaultBuildInvocation.java
index 5cfd42eebc..3dad1685c1 100644
--- a/impl/maven-core/src/main/java/org/apache/maven/internal/build/DefaultBuildInvocation.java
+++ b/impl/maven-core/src/main/java/org/apache/maven/internal/build/DefaultBuildInvocation.java
@@ -46,7 +46,6 @@
* @param reactorFailureBehavior reactor failure behavior
* @param offline whether offline mode was active
* @param updateSnapshots whether snapshot updates were forced
- * @param noTransferProgress whether transfer progress was suppressed
* @param batchMode whether batch mode was active
* @param recursive whether recursive processing is enabled
* @param resume whether resume mode was active
@@ -64,7 +63,6 @@ public record DefaultBuildInvocation(
ReactorFailureBehavior reactorFailureBehavior,
boolean offline,
boolean updateSnapshots,
- boolean noTransferProgress,
boolean batchMode,
boolean recursive,
boolean resume,
@@ -160,7 +158,6 @@ public static BuildInvocation from(MavenSession session) {
failureBehavior,
request.isOffline(),
request.isUpdateSnapshots(),
- request.isNoTransferProgress(),
!request.isInteractiveMode(),
request.isRecursive(),
request.isResume(),
diff --git a/impl/maven-core/src/test/java/org/apache/maven/internal/build/DefaultBuildInvocationTest.java b/impl/maven-core/src/test/java/org/apache/maven/internal/build/DefaultBuildInvocationTest.java
index 35188edd3b..dbf5119dd1 100644
--- a/impl/maven-core/src/test/java/org/apache/maven/internal/build/DefaultBuildInvocationTest.java
+++ b/impl/maven-core/src/test/java/org/apache/maven/internal/build/DefaultBuildInvocationTest.java
@@ -145,18 +145,6 @@ void resumeFromNull() {
assertNull(inv.resumeFrom());
}
- @Test
- void noTransferProgress() {
- MavenExecutionRequest request = newRequest();
- request.setNoTransferProgress(true);
- MavenSession session = mock(MavenSession.class);
- when(session.getRequest()).thenReturn(request);
-
- BuildInvocation inv = DefaultBuildInvocation.from(session);
-
- assertTrue(inv.noTransferProgress());
- }
-
@Test
void sensitiveKeyRedaction() {
MavenExecutionRequest request = newRequest();
@@ -230,7 +218,6 @@ void collectionsAreImmutable() {
false,
false,
false,
- false,
true,
false,
1);