You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2017/07/19 12:10:54 UTC

Review Request 60966: Log Search docker test environment build front/backend only

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60966/
-----------------------------------------------------------

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-21516
    https://issues.apache.org/jira/browse/AMBARI-21516


Repository: ambari


Description
-------

Building the logsearch project for testing on docker takes some time, while often only the backend / frontend was modified. It should be configurable what to build.


Diffs
-----

  ambari-logsearch/docker/logsearch-docker.sh 4d53fa1 


Diff: https://reviews.apache.org/r/60966/diff/1/


Testing
-------

Done.


Thanks,

Miklos Gergely


Re: Review Request 60966: Log Search docker test environment build front/backend only

Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60966/#review180923
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Nettleton


On July 19, 2017, 12:22 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60966/
> -----------------------------------------------------------
> 
> (Updated July 19, 2017, 12:22 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21516
>     https://issues.apache.org/jira/browse/AMBARI-21516
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Building the logsearch project for testing on docker takes some time, while often only the backend / frontend was modified. It should be configurable what to build.
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/docker/logsearch-docker.sh 4d53fa1 
> 
> 
> Diff: https://reviews.apache.org/r/60966/diff/2/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>


Re: Review Request 60966: Log Search docker test environment build front/backend only

Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60966/
-----------------------------------------------------------

(Updated July 19, 2017, 12:22 p.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
-------

Added documentation


Bugs: AMBARI-21516
    https://issues.apache.org/jira/browse/AMBARI-21516


Repository: ambari


Description
-------

Building the logsearch project for testing on docker takes some time, while often only the backend / frontend was modified. It should be configurable what to build.


Diffs (updated)
-----

  ambari-logsearch/docker/logsearch-docker.sh 4d53fa1 


Diff: https://reviews.apache.org/r/60966/diff/2/

Changes: https://reviews.apache.org/r/60966/diff/1-2/


Testing
-------

Done.


Thanks,

Miklos Gergely


Re: Review Request 60966: Log Search docker test environment build front/backend only

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60966/#review180918
-----------------------------------------------------------


Ship it!




Ship It!

(note: add some docs for the flags)

- Oliver Szabo


On July 19, 2017, 12:10 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60966/
> -----------------------------------------------------------
> 
> (Updated July 19, 2017, 12:10 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21516
>     https://issues.apache.org/jira/browse/AMBARI-21516
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Building the logsearch project for testing on docker takes some time, while often only the backend / frontend was modified. It should be configurable what to build.
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/docker/logsearch-docker.sh 4d53fa1 
> 
> 
> Diff: https://reviews.apache.org/r/60966/diff/1/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>