You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "bipinprasad (via GitHub)" <gi...@apache.org> on 2023/04/07 21:02:00 UTC
[GitHub] [storm] bipinprasad opened a new pull request, #3536: [STORM-3911] fetch net.minidev:json-smart:2.3 artifact from maven repo before conjars.org repo is referenced
bipinprasad opened a new pull request, #3536:
URL: https://github.com/apache/storm/pull/3536
## What is the purpose of the change
*Transitive dependency from hadoop-auth pulls in net.minidev:json-smart from http://conjars.org. conjars.org site is no longer active. And timeouts in the build process adds a very significant time to the build process. Adding json-smart as a dependency ensures that it is downloaded from the maven repo first, where the artifact exists.*
## How was the change tested
*Build the storm project*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] bipinprasad commented on pull request #3536: [STORM-3911] fetch net.minidev:json-smart:2.3 artifact from maven repo before conjars.org repo is referenced
Posted by "bipinprasad (via GitHub)" <gi...@apache.org>.
bipinprasad commented on PR #3536:
URL: https://github.com/apache/storm/pull/3536#issuecomment-1549890589
Hadoop v3 upgrade may be require a more discussion because of widespread use of v2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] bipinprasad commented on a diff in pull request #3536: [STORM-3911] fetch net.minidev:json-smart:2.3 artifact from maven repo before conjars.org repo is referenced
Posted by "bipinprasad (via GitHub)" <gi...@apache.org>.
bipinprasad commented on code in PR #3536:
URL: https://github.com/apache/storm/pull/3536#discussion_r1213687480
##########
storm-core/pom.xml:
##########
@@ -137,6 +137,7 @@
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
+ <version>${mockito.version}</version>
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] rzo1 commented on pull request #3536: [STORM-3911] fetch net.minidev:json-smart:2.3 artifact from maven repo before conjars.org repo is referenced
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #3536:
URL: https://github.com/apache/storm/pull/3536#issuecomment-1547253598
Shouldn't we try to upgrade to hadoop 3.x.x or is it meant as a temporary workaround ? Think they already fixed it in the v3 series.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] bipinprasad merged pull request #3536: [STORM-3911] fetch net.minidev:json-smart:2.3 artifact from maven repo before conjars.org repo is referenced
Posted by "bipinprasad (via GitHub)" <gi...@apache.org>.
bipinprasad merged PR #3536:
URL: https://github.com/apache/storm/pull/3536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] bipinprasad commented on pull request #3536: [STORM-3911] fetch net.minidev:json-smart:2.3 artifact from maven repo before conjars.org repo is referenced
Posted by "bipinprasad (via GitHub)" <gi...@apache.org>.
bipinprasad commented on PR #3536:
URL: https://github.com/apache/storm/pull/3536#issuecomment-1549949009
Created https://issues.apache.org/jira/browse/STORM-3919
@rzo1 if you want to create a separate PR for it, that would be very welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] agresch commented on a diff in pull request #3536: [STORM-3911] fetch net.minidev:json-smart:2.3 artifact from maven repo before conjars.org repo is referenced
Posted by "agresch (via GitHub)" <gi...@apache.org>.
agresch commented on code in PR #3536:
URL: https://github.com/apache/storm/pull/3536#discussion_r1213655650
##########
storm-core/pom.xml:
##########
@@ -137,6 +137,7 @@
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
+ <version>${mockito.version}</version>
Review Comment:
why was this line added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org