You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/12/21 10:07:04 UTC
[GitHub] [ignite] nizhikov opened a new pull request #9677: IGNITE-16180 Thin Client: Get service description implemented
nizhikov opened a new pull request #9677:
URL: https://github.com/apache/ignite/pull/9677
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a change in pull request #9677: IGNITE-16180 Thin Client get service description implemented
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on a change in pull request #9677:
URL: https://github.com/apache/ignite/pull/9677#discussion_r773207054
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientServicesImpl.java
##########
@@ -74,6 +79,62 @@
new ServiceInvocationHandler<>(name, timeout, grp));
}
+ /** {@inheritDoc} */
+ @Override public Collection<ClientServiceDescriptor> serviceDescriptors() {
+ return ch.service(ClientOperation.SERVICE_GET_DESCRIPTORS,
+ req -> checkGetServiceDescriptorsSupported(req.clientChannel().protocolCtx()),
+ res -> {
+ try (BinaryReaderExImpl reader = utils.createBinaryReader(res.in())) {
+ int sz = res.in().readInt();
+
+ Collection<ClientServiceDescriptor> svcs = new ArrayList<>();
+
+ for (int i = 0; i < sz; i++)
+ svcs.add(readServiceDescriptor(reader));
+
+ return svcs;
+ }
+ catch (IOException e) {
+ throw new ClientError(e);
+ }
+ }
+ );
+ }
+
+ /** {@inheritDoc} */
+ @Override public ClientServiceDescriptor serviceDescriptor(String name) {
+ return ch.service(ClientOperation.SERVICE_GET_DESCRIPTOR,
Review comment:
I think `name` can't be null, let's add a check.
##########
File path: modules/core/src/main/java/org/apache/ignite/services/ServiceConfiguration.java
##########
@@ -77,6 +77,25 @@
@GridToStringExclude
protected IgnitePredicate<ClusterNode> nodeFilter;
+ /** Default constructor. */
+ public ServiceConfiguration() {
+ // No-op.
+ }
+
+ /**
+ * Copy constructor.
+ * @param cfg Configuration to copy.
+ */
+ public ServiceConfiguration(ServiceConfiguration cfg) {
+ name = cfg.name;
Review comment:
Missing `cfg` null check.
##########
File path: modules/core/src/main/java/org/apache/ignite/client/ClientServiceDescriptor.java
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.client;
+
+import java.util.UUID;
+import org.apache.ignite.services.Service;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Descriptor of {@link Service}.
+ */
+public interface ClientServiceDescriptor {
+ /**
+ * Gets service name.
+ *
+ * @return Service name.
+ */
+ public String name();
+
+ /**
+ * Gets service class.
+ *
+ * @return Service class.
+ */
+ public String serviceClass();
+
+ /**
+ * Gets maximum allowed total number of deployed services in the grid, {@code 0} for unlimited.
+ *
+ * @return Maximum allowed total number of deployed services in the grid, {@code 0} for unlimited.
+ */
+ public int totalCount();
+
+ /**
+ * Gets maximum allowed number of deployed services on each node, {@code 0} for unlimited.
+ *
+ * @return Maximum allowed total number of deployed services on each node, {@code 0} for unlimited.
+ */
+ public int maxPerNodeCount();
+
+ /**
+ * Gets cache name used for key-to-node affinity calculation. This parameter is optional
+ * and is set only when key-affinity service was deployed.
+ *
+ * @return Cache name, possibly {@code null}.
+ */
+ @Nullable public String cacheName();
+
+ /**
+ * Gets ID of grid node that initiated the service deployment.
+ *
+ * @return ID of grid node that initiated the service deployment.
+ */
+ public UUID originNodeId();
+
+ /**
+ * Platform id.
+ * <ul>
+ * <li>{@code 0} is Java platform service.</li>
+ * <li>{@code 1} is .Net platform service.</li>
+ * </ul>
+ * @return Map of number of service instances per node ID.
+ */
+ public byte platformId();
Review comment:
I think an `enum` would be better for the public API.
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientServicesImpl.java
##########
@@ -74,6 +79,62 @@
new ServiceInvocationHandler<>(name, timeout, grp));
}
+ /** {@inheritDoc} */
+ @Override public Collection<ClientServiceDescriptor> serviceDescriptors() {
+ return ch.service(ClientOperation.SERVICE_GET_DESCRIPTORS,
+ req -> checkGetServiceDescriptorsSupported(req.clientChannel().protocolCtx()),
+ res -> {
+ try (BinaryReaderExImpl reader = utils.createBinaryReader(res.in())) {
+ int sz = res.in().readInt();
+
+ Collection<ClientServiceDescriptor> svcs = new ArrayList<>();
Review comment:
```suggestion
Collection<ClientServiceDescriptor> svcs = new ArrayList<>(sz);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a change in pull request #9677: IGNITE-16180 Thin Client get service description implemented
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #9677:
URL: https://github.com/apache/ignite/pull/9677#discussion_r773234922
##########
File path: modules/core/src/main/java/org/apache/ignite/client/ClientServiceDescriptor.java
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.client;
+
+import java.util.UUID;
+import org.apache.ignite.services.Service;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Descriptor of {@link Service}.
+ */
+public interface ClientServiceDescriptor {
+ /**
+ * Gets service name.
+ *
+ * @return Service name.
+ */
+ public String name();
+
+ /**
+ * Gets service class.
+ *
+ * @return Service class.
+ */
+ public String serviceClass();
+
+ /**
+ * Gets maximum allowed total number of deployed services in the grid, {@code 0} for unlimited.
+ *
+ * @return Maximum allowed total number of deployed services in the grid, {@code 0} for unlimited.
+ */
+ public int totalCount();
+
+ /**
+ * Gets maximum allowed number of deployed services on each node, {@code 0} for unlimited.
+ *
+ * @return Maximum allowed total number of deployed services on each node, {@code 0} for unlimited.
+ */
+ public int maxPerNodeCount();
+
+ /**
+ * Gets cache name used for key-to-node affinity calculation. This parameter is optional
+ * and is set only when key-affinity service was deployed.
+ *
+ * @return Cache name, possibly {@code null}.
+ */
+ @Nullable public String cacheName();
+
+ /**
+ * Gets ID of grid node that initiated the service deployment.
+ *
+ * @return ID of grid node that initiated the service deployment.
+ */
+ public UUID originNodeId();
+
+ /**
+ * Platform id.
+ * <ul>
+ * <li>{@code 0} is Java platform service.</li>
+ * <li>{@code 1} is .Net platform service.</li>
+ * </ul>
+ * @return Map of number of service instances per node ID.
+ */
+ public byte platformId();
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a change in pull request #9677: IGNITE-16180 Thin Client get service description implemented
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #9677:
URL: https://github.com/apache/ignite/pull/9677#discussion_r773239005
##########
File path: modules/core/src/main/java/org/apache/ignite/client/PlatformType.java
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.client;
+
+/**
+ * Type of the platform service implemented on.
+ */
+public enum PlatformType {
+ /** Service implemented on java platform. */
Review comment:
Fixed
##########
File path: modules/core/src/main/java/org/apache/ignite/client/PlatformType.java
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.client;
+
+/**
+ * Type of the platform service implemented on.
+ */
+public enum PlatformType {
+ /** Service implemented on java platform. */
+ JAVA,
+
+ /** Service implemented on .Net platform. */
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a change in pull request #9677: IGNITE-16180 Thin Client get service description implemented
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #9677:
URL: https://github.com/apache/ignite/pull/9677#discussion_r773239382
##########
File path: modules/core/src/main/java/org/apache/ignite/client/PlatformType.java
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.client;
+
+/**
+ * Type of the platform service implemented on.
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a change in pull request #9677: IGNITE-16180 Thin Client get service description implemented
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on a change in pull request #9677:
URL: https://github.com/apache/ignite/pull/9677#discussion_r773237414
##########
File path: modules/core/src/main/java/org/apache/ignite/client/PlatformType.java
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.client;
+
+/**
+ * Type of the platform service implemented on.
+ */
+public enum PlatformType {
+ /** Service implemented on java platform. */
Review comment:
```suggestion
/** Java platform. */
```
##########
File path: modules/core/src/main/java/org/apache/ignite/client/PlatformType.java
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.client;
+
+/**
+ * Type of the platform service implemented on.
+ */
+public enum PlatformType {
+ /** Service implemented on java platform. */
+ JAVA,
+
+ /** Service implemented on .Net platform. */
Review comment:
```suggestion
/** .NET platform. */
```
##########
File path: modules/core/src/main/java/org/apache/ignite/client/PlatformType.java
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.client;
Review comment:
Let's move this to `org.apache.ignite.platform` package.
##########
File path: modules/core/src/main/java/org/apache/ignite/client/PlatformType.java
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.client;
+
+/**
+ * Type of the platform service implemented on.
Review comment:
```suggestion
* Interop platform type.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a change in pull request #9677: IGNITE-16180 Thin Client get service description implemented
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #9677:
URL: https://github.com/apache/ignite/pull/9677#discussion_r773238611
##########
File path: modules/core/src/main/java/org/apache/ignite/client/PlatformType.java
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.client;
Review comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a change in pull request #9677: IGNITE-16180 Thin Client get service description implemented
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #9677:
URL: https://github.com/apache/ignite/pull/9677#discussion_r773220796
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientServicesImpl.java
##########
@@ -74,6 +79,62 @@
new ServiceInvocationHandler<>(name, timeout, grp));
}
+ /** {@inheritDoc} */
+ @Override public Collection<ClientServiceDescriptor> serviceDescriptors() {
+ return ch.service(ClientOperation.SERVICE_GET_DESCRIPTORS,
+ req -> checkGetServiceDescriptorsSupported(req.clientChannel().protocolCtx()),
+ res -> {
+ try (BinaryReaderExImpl reader = utils.createBinaryReader(res.in())) {
+ int sz = res.in().readInt();
+
+ Collection<ClientServiceDescriptor> svcs = new ArrayList<>();
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a change in pull request #9677: IGNITE-16180 Thin Client get service description implemented
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #9677:
URL: https://github.com/apache/ignite/pull/9677#discussion_r773221069
##########
File path: modules/core/src/main/java/org/apache/ignite/services/ServiceConfiguration.java
##########
@@ -77,6 +77,25 @@
@GridToStringExclude
protected IgnitePredicate<ClusterNode> nodeFilter;
+ /** Default constructor. */
+ public ServiceConfiguration() {
+ // No-op.
+ }
+
+ /**
+ * Copy constructor.
+ * @param cfg Configuration to copy.
+ */
+ public ServiceConfiguration(ServiceConfiguration cfg) {
+ name = cfg.name;
Review comment:
Sorry. Unrelated changes. reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov merged pull request #9677: IGNITE-16180 Thin Client get service description implemented
Posted by GitBox <gi...@apache.org>.
nizhikov merged pull request #9677:
URL: https://github.com/apache/ignite/pull/9677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org