You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/11/09 03:46:08 UTC

[GitHub] [rocketmq] lovelife-li opened a new pull request #2411: reason: if code no use;

lovelife-li opened a new pull request #2411:
URL: https://github.com/apache/rocketmq/pull/2411


   reason: if code no use;
   index = Math.abs(random.nextInt());
   if (index < 0)
       index = 0;
   
   fix：
   delete if code
   
   ## What is the purpose of the change
   
   delete no use code
   
   ## Brief changelog
   
   delete no use code
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lovelife-li commented on pull request #2411: [ISSUE#2415] Delete the useless code

Posted by GitBox <gi...@apache.org>.
lovelife-li commented on pull request #2411:
URL: https://github.com/apache/rocketmq/pull/2411#issuecomment-723968553


   commit tow same pull request , close this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #2411: [ISSUE#2415] Delete the useless code

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2411:
URL: https://github.com/apache/rocketmq/pull/2411#issuecomment-723739695


   
   [![Coverage Status](https://coveralls.io/builds/34820410/badge)](https://coveralls.io/builds/34820410)
   
   Coverage increased (+0.02%) to 51.322% when pulling **d5cee4faced0e7e2fb3bf261966db20c53336739 on lovelife-li:master** into **9f95a972e10e0681bc3f2d00e9957aa212e897b5 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #2411: reason: if code no use;

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2411:
URL: https://github.com/apache/rocketmq/pull/2411#issuecomment-723739695


   
   [![Coverage Status](https://coveralls.io/builds/34807650/badge)](https://coveralls.io/builds/34807650)
   
   Coverage decreased (-0.1%) to 51.164% when pulling **96f6040a373ce3648da4fdba108013340a72d88e on lovelife-li:master** into **9f95a972e10e0681bc3f2d00e9957aa212e897b5 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on pull request #2411: reason: if code no use;

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #2411:
URL: https://github.com/apache/rocketmq/pull/2411#issuecomment-723889234


   Plz create an issue link to the pull request and change the target branch to develop.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lovelife-li commented on pull request #2411: reason: if code no use;

Posted by GitBox <gi...@apache.org>.
lovelife-li commented on pull request #2411:
URL: https://github.com/apache/rocketmq/pull/2411#issuecomment-723745342


   why fail?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lovelife-li closed pull request #2411: [ISSUE#2415] Delete the useless code

Posted by GitBox <gi...@apache.org>.
lovelife-li closed pull request #2411:
URL: https://github.com/apache/rocketmq/pull/2411


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org