You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2022/09/18 08:25:39 UTC

[GitHub] [submarine] FatalLin commented on a diff in pull request #989: SUBMARINE-1283. copy data for experiment before it running via distcp to minio

FatalLin commented on code in PR #989:
URL: https://github.com/apache/submarine/pull/989#discussion_r973681570


##########
.github/scripts/build-image-locally-v3.sh:
##########
@@ -17,12 +17,14 @@
 #
 
 SUBMARINE_VERSION="0.8.0-SNAPSHOT"

Review Comment:
   In my opinion, maybe we could create another text file call submarine.version or something else and it would be the source of project version, all the metadata could read from it, include pom.xml, build script, and anything else.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org