You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by GitBox <gi...@apache.org> on 2023/01/18 08:53:09 UTC

[GitHub] [incubator-celeborn] kaijchen opened a new pull request, #1172: [CELEBORN-230] AppDiskUsageSnapShot overrides equals() without override hashCode()

kaijchen opened a new pull request, #1172:
URL: https://github.com/apache/incubator-celeborn/pull/1172

   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   
   
   ### Why are the changes needed?
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   
   ### How was this patch tested?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1172: [CELEBORN-230] AppDiskUsageSnapShot overrides equals() without override hashCode()

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1172:
URL: https://github.com/apache/incubator-celeborn/pull/1172#issuecomment-1386710536

   # [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1172?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1172](https://codecov.io/gh/apache/incubator-celeborn/pull/1172?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b6bd97a) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/e219e8b44ea14495d7a7d1f71dc99f6c74d40dd1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e219e8b) will **increase** coverage by `0.07%`.
   > The diff coverage is `59.10%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #1172      +/-   ##
   ============================================
   + Coverage     27.01%   27.08%   +0.07%     
   - Complexity      760      764       +4     
   ============================================
     Files           200      200              
     Lines         17172    17180       +8     
     Branches       1858     1862       +4     
   ============================================
   + Hits           4638     4652      +14     
   + Misses        12216    12210       -6     
     Partials        318      318              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ache/celeborn/common/meta/AppDiskUsageMetric.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldGEvQXBwRGlza1VzYWdlTWV0cmljLnNjYWxh) | `0.00% <0.00%> (ø)` | |
   | [...ce/deploy/worker/storage/PartitionFilesSorter.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS93b3JrZXIvc3RvcmFnZS9QYXJ0aXRpb25GaWxlc1NvcnRlci5qYXZh) | `68.05% <60.00%> (+0.91%)` | :arrow_up: |
   | [...cala/org/apache/celeborn/common/CelebornConf.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL0NlbGVib3JuQ29uZi5zY2FsYQ==) | `80.62% <100.00%> (ø)` | |
   | [...celeborn/service/deploy/master/SlotsAllocator.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvU2xvdHNBbGxvY2F0b3IuamF2YQ==) | `71.73% <0.00%> (+2.46%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1172: [CELEBORN-230] AppDiskUsageSnapShot overrides equals() without override hashCode()

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on PR #1172:
URL: https://github.com/apache/incubator-celeborn/pull/1172#issuecomment-1386704413

   pls run `./dev/reformat` to format the code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] waitinfuture merged pull request #1172: [CELEBORN-230] AppDiskUsageSnapShot overrides equals() without override hashCode()

Posted by GitBox <gi...@apache.org>.
waitinfuture merged PR #1172:
URL: https://github.com/apache/incubator-celeborn/pull/1172


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] kaijchen commented on pull request #1172: [CELEBORN-230] AppDiskUsageSnapShot overrides equals() without override hashCode()

Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #1172:
URL: https://github.com/apache/incubator-celeborn/pull/1172#issuecomment-1386734597

   Thanks @AngersZhuuuu and @waitinfuture for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org