Re: [I] Fix `HoodieRecord.getOrderingValue` to be engine agnostic [hudi]

["nsivabalan (via GitHub)" <gi...@apache.org>]

nsivabalan commented on issue #17114:
URL: https://github.com/apache/hudi/issues/17114#issuecomment-4800779547

   This appears to be resolved in current master.
   
   - The performance concern (passing the ordering field name as a parameter instead of extracting from props per-record) was fixed by [HUDI-9661](https://issues.apache.org/jira/browse/HUDI-9661) in commit `e0fa459f1516`. `HoodieRecord.getOrderingValue` now accepts `String[] orderingFields` directly.
   - The engine-agnostic concern (so values can be safely serialized into `DeleteRecord` log blocks) was addressed by commit `3e45b5279aab` (`getOrderingValueAsJava(...)` on `HoodieRecord`) and commit `adbea027727a` (added `OrderingValueEngineTypeConverter` to convert Flink/Spark engine types back to Java types when reading delete log blocks).
   
   Could this issue / HUDI-9643 be closed as a duplicate of HUDI-9661, or is there a remaining gap not covered by the above commits?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org