You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2016/03/10 13:05:21 UTC
[GitHub] brooklyn-dist pull request: revised go cli exclusion, and tweaked ...
GitHub user ahgittin opened a pull request:
https://github.com/apache/brooklyn-dist/pull/15
revised go cli exclusion, and tweaked license generation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/brooklyn-dist go-cli
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-dist/pull/15.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15
----
commit 5bc7080a42536d2ce6a109729aaacfe2952796dc
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date: 2016-02-19T16:22:10Z
Add brooklyn-client-cli as a dependency.
This will mean that the build includes the archive for the client CLI
in lib/brooklyn, e.g.
lib/brooklyn/org.apache.brooklyn-brooklyn-client-cli-0.9.0-SNAPSHOT-bin.zip
commit fb30a9cbbbdaa7dc27378f27352ba96f58b3f1fa
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date: 2016-02-23T14:57:42Z
Include brooklyn-client-cli artifacts
commit f7e8eddc24835f197782ecddfbc1c13f21820851
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date: 2016-02-24T21:06:42Z
Fix paths in projects-with-custom-licenses
commit 7d55d53318bd97357b57a4132ebc2a5b7e3602ac
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date: 2016-02-25T16:20:58Z
Start of work to add license files for CLI, NOT WORKING YET.
commit 1bf00c1e9405747ffe5b1543d8e62ca8b3fa6774
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date: 2016-02-26T12:17:16Z
Updates for license for brooklyn-client, now working.
commit 98389cda4c25099f17b3eb7b9f8b232131996907
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date: 2016-03-09T21:17:10Z
Add no-go-client profile to avoid including brooklyn-client artifacts.
commit d534b9563ad0d0e5052841c47835fb53a4de0eec
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2016-03-10T09:37:33Z
This closes #14
commit 3d801c6b2fc474f994d411d97b6074f9dd47a801
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2016-03-10T10:07:39Z
write cli binaries to a directory without the version name
commit b213524c3f94bea472da698990bc55a84be37d7c
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2016-03-10T10:38:01Z
switch go-client profile to be activated based on property
commit c056640e106660f482ed06d15d2f1c0d98fdd4df
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2016-03-10T10:45:07Z
update how go client cli licenses generated
point at new location of license files, tweak scripts to support that, use embedded notices like other projects, and add text of referenced licenses
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: revised go cli exclusion, and tweaked ...
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/15#discussion_r55671568
--- Diff: dist/pom.xml ---
@@ -156,4 +156,47 @@
</plugin>
</plugins>
</build>
+
+ <profiles>
+ <profile>
+ <id>go-client</id>
+ <activation>
+ <property>
+ <name>!no-go-client</name>
+ </property>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>unpack-client-cli</id>
+ <phase>prepare-package</phase>
+ <goals>
+ <goal>unpack</goal>
+ </goals>
+ <configuration>
+ <artifactItems>
+ <artifactItem>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>brooklyn-client-cli</artifactId>
+ <classifier>bin</classifier>
+ <type>zip</type>
+ <version>${project.version}</version>
+ <outputDirectory>${project.build.directory}/brooklyn-client-cli-unpacked</outputDirectory>
+ </artifactItem>
+ </artifactItems>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+ <profile>
--- End diff --
Do you still need this no-op profile, 'no-go-client'?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: revised go cli exclusion, and tweaked ...
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/15#issuecomment-194819507
:+1: lgtm, comment above is extremely minor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: revised go cli exclusion, and tweaked ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-dist/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: revised go cli exclusion, and tweaked ...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/15#issuecomment-194819735
good spot, removed it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---