You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "wuwen5 (via GitHub)" <gi...@apache.org> on 2024/07/09 06:17:04 UTC
[PR] Fix cache scheduled refresh issue. [incubator-seata]
wuwen5 opened a new pull request, #6661:
URL: https://github.com/apache/incubator-seata/pull/6661
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
Restore some code and fix cache scheduled refresh issue.
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
fixes #6660
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: fix cache scheduled refresh issue. [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on PR #6661:
URL: https://github.com/apache/incubator-seata/pull/6661#issuecomment-2216837671
请把你的钉钉联系方式发送至：jianbin@apache.org 我将邀请你加入seata开发者群中
Please send me your DingTalk contact information to jianbin@apache.org. I will invite you to join the Seata developers group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] Fix cache scheduled refresh issue. [incubator-seata]
Posted by "wuwen5 (via GitHub)" <gi...@apache.org>.
wuwen5 commented on PR #6661:
URL: https://github.com/apache/incubator-seata/pull/6661#issuecomment-2216692244
> 我认为应该将take改为poll，加上超时时间就可以了，不需要独立一个线程去处理这个刷新缓存时间，你觉得呢？ I think we should change "take" to "poll" and add a timeout, that should be enough. We don't need a separate thread to handle the cache refresh time. What do you think about that?
OK， Good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: fix cache scheduled refresh issue. [incubator-seata]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6661:
URL: https://github.com/apache/incubator-seata/pull/6661#issuecomment-2216847408
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6661?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `33.33333%` with `4 lines` in your changes missing coverage. Please review.
> Project coverage is 50.77%. Comparing base [(`933b492`)](https://app.codecov.io/gh/apache/incubator-seata/commit/933b492da88e145ca2b7f152ed3b03693936b068?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`5b965de`)](https://app.codecov.io/gh/apache/incubator-seata/commit/5b965de887619676729e453b185654b639486dbf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 35 commits behind head on 2.x.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/incubator-seata/pull/6661?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 2.x #6661 +/- ##
============================================
- Coverage 51.13% 50.77% -0.36%
- Complexity 5317 5642 +325
============================================
Files 950 1023 +73
Lines 33448 35440 +1992
Branches 4048 4216 +168
============================================
+ Hits 17103 17995 +892
- Misses 14666 15644 +978
- Partials 1679 1801 +122
```
| [Files](https://app.codecov.io/gh/apache/incubator-seata/pull/6661?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...m/datasource/sql/struct/TableMetaCacheFactory.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6661?src=pr&el=tree&filepath=rm-datasource%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Frm%2Fdatasource%2Fsql%2Fstruct%2FTableMetaCacheFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cm0tZGF0YXNvdXJjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvcm0vZGF0YXNvdXJjZS9zcWwvc3RydWN0L1RhYmxlTWV0YUNhY2hlRmFjdG9yeS5qYXZh) | `57.89% <33.33%> (+5.26%)` | :arrow_up: |
... and [107 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6661/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: fix cache scheduled refresh issue. [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #6661:
URL: https://github.com/apache/incubator-seata/pull/6661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] Fix cache scheduled refresh issue. [incubator-seata]
Posted by "wuwen5 (via GitHub)" <gi...@apache.org>.
wuwen5 commented on PR #6661:
URL: https://github.com/apache/incubator-seata/pull/6661#issuecomment-2216746283
@funky-eyes
已经修改，同时我将`currentTimeMillis`改为了`nanoTime`,因为计算时间流逝应该使用单调时间而不是挂钟时间，避免时钟回拨问题.
It has been modified, and at the same time, I have changed the `currentTimeMillis` to `nanoTime` because calculating the passage of time should use monotonic time instead of clock time to avoid clock back issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org