You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "shuyouZZ (via GitHub)" <gi...@apache.org> on 2023/08/07 11:00:18 UTC
[GitHub] [spark] shuyouZZ opened a new pull request, #42378: SPARK-44703. Log eventLog rewrite duration when compact old event log files
shuyouZZ opened a new pull request, #42378:
URL: https://github.com/apache/spark/pull/42378
### What changes were proposed in this pull request?
Log eventLog rewrite duration when compact old event log files.
### Why are the changes needed?
When enable `spark.eventLog.rolling.enabled` and the number of eventLog files exceeds the value of `spark.history.fs.eventLog.rolling.maxFilesToRetain`, HistoryServer will compact the old event log files into one compact file.
Currently there is no log the rewrite duration in rewrite method, this metric is useful for understand the compact duration, so we need add logs in the method.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Manual test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #42378: [SPARK-44703][CORE] Log eventLog rewrite duration when compact old event log files
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42378:
URL: https://github.com/apache/spark/pull/42378#issuecomment-1668725457
cc @HeartSaVioR FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #42378: [SPARK-44703][CORE] Log eventLog rewrite duration when compact old event log files
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #42378:
URL: https://github.com/apache/spark/pull/42378#discussion_r1286623320
##########
core/src/main/scala/org/apache/spark/deploy/history/EventLogFileCompactor.scala:
##########
@@ -158,6 +159,8 @@ class EventLogFileCompactor(
)
}
logWriter.stop()
+ val duration = System.currentTimeMillis() - startTime
Review Comment:
How about directly using `Utils.timeTakenMs`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shuyouZZ commented on a diff in pull request #42378: [SPARK-44703][CORE] Log eventLog rewrite duration when compact old event log files
Posted by "shuyouZZ (via GitHub)" <gi...@apache.org>.
shuyouZZ commented on code in PR #42378:
URL: https://github.com/apache/spark/pull/42378#discussion_r1286636112
##########
core/src/main/scala/org/apache/spark/deploy/history/EventLogFileCompactor.scala:
##########
@@ -158,6 +159,8 @@ class EventLogFileCompactor(
)
}
logWriter.stop()
+ val duration = System.currentTimeMillis() - startTime
Review Comment:
I see, using `Utils.timeTakenMs` is also a good choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shuyouZZ commented on pull request #42378: [SPARK-44703][CORE] Log eventLog rewrite duration when compact old event log files
Posted by "shuyouZZ (via GitHub)" <gi...@apache.org>.
shuyouZZ commented on PR #42378:
URL: https://github.com/apache/spark/pull/42378#issuecomment-1667698473
> System.nanoTime() returns time in nanoseconds, so the log will not be correct when text is in "ms"
>
> scala> val startTime = System.nanoTime() startTime: Long = [18704686566177](tel:18704686566177)
>
> scala> val duration = System.nanoTime() - startTime duration: Long = [8908577884](tel:8908577884)
>
> scala> print(s"$duration ms.") [8908577884](tel:8908577884) ms.
Oh, it's my mistake, i will update here later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR closed pull request #42378: [SPARK-44703][CORE] Log eventLog rewrite duration when compact old event log files
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR closed pull request #42378: [SPARK-44703][CORE] Log eventLog rewrite duration when compact old event log files
URL: https://github.com/apache/spark/pull/42378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #42378: [SPARK-44703][CORE] Log eventLog rewrite duration when compact old event log files
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on PR #42378:
URL: https://github.com/apache/spark/pull/42378#issuecomment-1668844958
Thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org