You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/15 22:10:39 UTC

[GitHub] [airflow] o-nikolas opened a new pull request #16469: Update Watchtower version to 1.0.6

o-nikolas opened a new pull request #16469:
URL: https://github.com/apache/airflow/pull/16469


   Currently a pre 1.0 version of Watchtower is being used. There have been
   many bug fixes and improvements since this version (the changelog can be found [here](https://github.com/kislyuk/watchtower/blob/develop/Changes.rst)).
   
   This change updates Airflow's specified version in setup.py.
   
   I have ran the following commands to test this locally:
   
   `./breeze generate-constraints --generate-constraints-mode source-providers`
   
   `./scripts/ci/testing/ci_run_airflow_testing.sh`
   
   I believe this is the only line that needs to be changed for a dependency upgrade ([see discussion I started on the community slack](https://apache-airflow.slack.com/archives/CCPRP7943/p1621024646304600)) but please correct me if I'm wrong here.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #16469: Update Watchtower version to 1.0.6

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16469:
URL: https://github.com/apache/airflow/pull/16469#issuecomment-861879985


   This one will fail likely . I looked at this and some recent change made "setup.py' changes do not work the way they should. Fix is coming https://github.com/apache/airflow/pull/16470
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on pull request #16469: Update Watchtower version to 1.0.6

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #16469:
URL: https://github.com/apache/airflow/pull/16469#issuecomment-863827298


   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #16469: Update Watchtower version to 1.0.6

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16469:
URL: https://github.com/apache/airflow/pull/16469#issuecomment-863533714


   🀞 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #16469: Update Watchtower version to 1.0.6

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #16469:
URL: https://github.com/apache/airflow/pull/16469


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on pull request #16469: Update Watchtower version to 1.0.6

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #16469:
URL: https://github.com/apache/airflow/pull/16469#issuecomment-861869601


   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better πŸš€.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org