You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Alan Woodward (JIRA)" <ji...@apache.org> on 2014/06/16 12:25:02 UTC
[jira] [Updated] (SOLR-6170) Merge 'pre-register', 'create' and
'register' core methods in CoreContainer
[ https://issues.apache.org/jira/browse/SOLR-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Woodward updated SOLR-6170:
--------------------------------
Attachment: SOLR-6170.patch
Patch moving the pre-register and register logic into CoreContainer.create(). Also does a bit of related method cleanup: the isTransient parameter to register can be read from the CoreDescriptor, and 'returnPrevNotClosed' was false everywhere the method was called.
> Merge 'pre-register', 'create' and 'register' core methods in CoreContainer
> ---------------------------------------------------------------------------
>
> Key: SOLR-6170
> URL: https://issues.apache.org/jira/browse/SOLR-6170
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.8.1, 5.0
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Minor
> Fix For: 4.9
>
> Attachments: SOLR-6170.patch
>
>
> We have a bunch of duplicated logic in CoreContainer startup, CoreAdminHandler core creation and core tests that always calls the same three methods, 'preRegisterInZk', 'create' and 'register'. These should really all be in one API call.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org