You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2008/03/11 07:22:46 UTC

[jira] Created: (HADOOP-2996) [PATCH] StreamUtils abuses StringBuffers

[PATCH] StreamUtils abuses StringBuffers
----------------------------------------

                 Key: HADOOP-2996
                 URL: https://issues.apache.org/jira/browse/HADOOP-2996
             Project: Hadoop Core
          Issue Type: Improvement
          Components: contrib/streaming
    Affects Versions: 0.16.0
            Reporter: Dave Brosius
            Priority: Trivial
             Fix For: 0.17.0
         Attachments: dont_abuse_stringbuffer.patch

Code does 

sb.append("foo" + n)

which corresponds to

sb.append(new StringBuffer("foo").append(n).toString())

patch fixes this.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2996) [PATCH] StreamUtils abuses StringBuffers

Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Brosius updated HADOOP-2996:
---------------------------------

    Attachment: dont_abuse_stringbuffer.patch

> [PATCH] StreamUtils abuses StringBuffers
> ----------------------------------------
>
>                 Key: HADOOP-2996
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2996
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/streaming
>    Affects Versions: 0.16.0
>            Reporter: Dave Brosius
>            Priority: Trivial
>             Fix For: 0.17.0
>
>         Attachments: dont_abuse_stringbuffer.patch
>
>
> Code does 
> sb.append("foo" + n)
> which corresponds to
> sb.append(new StringBuffer("foo").append(n).toString())
> patch fixes this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2996) StreamUtils abuses StringBuffers

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-2996:
----------------------------------

    Assignee: Dave Brosius
     Summary: StreamUtils abuses StringBuffers  (was: [PATCH] StreamUtils abuses StringBuffers)

> StreamUtils abuses StringBuffers
> --------------------------------
>
>                 Key: HADOOP-2996
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2996
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/streaming
>    Affects Versions: 0.16.0
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 0.17.0
>
>         Attachments: dont_abuse_stringbuffer.patch
>
>
> Code does 
> sb.append("foo" + n)
> which corresponds to
> sb.append(new StringBuffer("foo").append(n).toString())
> patch fixes this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2996) StreamUtils abuses StringBuffers

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578167#action_12578167 ] 

Hadoop QA commented on HADOOP-2996:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12377583/dont_abuse_stringbuffer.patch
against trunk revision 619744.

    @author +1.  The patch does not contain any @author tags.

    tests included -1.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1949/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1949/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1949/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1949/console

This message is automatically generated.

> StreamUtils abuses StringBuffers
> --------------------------------
>
>                 Key: HADOOP-2996
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2996
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/streaming
>    Affects Versions: 0.16.0
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 0.17.0
>
>         Attachments: dont_abuse_stringbuffer.patch
>
>
> Code does 
> sb.append("foo" + n)
> which corresponds to
> sb.append(new StringBuffer("foo").append(n).toString())
> patch fixes this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2996) StreamUtils abuses StringBuffers

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-2996:
----------------------------------

    Status: Patch Available  (was: Open)

> StreamUtils abuses StringBuffers
> --------------------------------
>
>                 Key: HADOOP-2996
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2996
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/streaming
>    Affects Versions: 0.16.0
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 0.17.0
>
>         Attachments: dont_abuse_stringbuffer.patch
>
>
> Code does 
> sb.append("foo" + n)
> which corresponds to
> sb.append(new StringBuffer("foo").append(n).toString())
> patch fixes this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2996) StreamUtils abuses StringBuffers

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-2996:
--------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Dave!

> StreamUtils abuses StringBuffers
> --------------------------------
>
>                 Key: HADOOP-2996
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2996
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/streaming
>    Affects Versions: 0.16.0
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 0.17.0
>
>         Attachments: dont_abuse_stringbuffer.patch
>
>
> Code does 
> sb.append("foo" + n)
> which corresponds to
> sb.append(new StringBuffer("foo").append(n).toString())
> patch fixes this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2996) StreamUtils abuses StringBuffers

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578289#action_12578289 ] 

Hudson commented on HADOOP-2996:
--------------------------------

Integrated in Hadoop-trunk #427 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/427/])

> StreamUtils abuses StringBuffers
> --------------------------------
>
>                 Key: HADOOP-2996
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2996
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/streaming
>    Affects Versions: 0.16.0
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 0.17.0
>
>         Attachments: dont_abuse_stringbuffer.patch
>
>
> Code does 
> sb.append("foo" + n)
> which corresponds to
> sb.append(new StringBuffer("foo").append(n).toString())
> patch fixes this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.