[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4187: [Improvement] Print revision commit date on server startup

[GitBox <gi...@apache.org>]

pan3793 commented on code in PR #4187:
URL: https://github.com/apache/kyuubi/pull/4187#discussion_r1081515696


##########
build/kyuubi-build-info:
##########
@@ -32,6 +32,7 @@ echo_build_properties() {
   echo kyuubi_trino_version="$9"
   echo user="$USER"
   echo revision=$(git rev-parse HEAD)
+  echo revision_date=$(git show -s --format=%ci HEAD)

Review Comment:
   "date" is confusing since that JSR 310 uses "date" to represent `year-month-day` and "time" to represent `hour:minute:sec[.]`, how about "revision_time" or "revision_timestamp"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org