You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by "spmallette (GitHub)" <gi...@apache.org> on 2018/12/13 16:42:25 UTC

[GitHub] [tinkerpop] spmallette opened pull request #1018: TINKERPOP-2111 Added BulkSet as a GraphSON Type

https://issues.apache.org/jira/browse/TINKERPOP-2111

Adding `BulkSet` brings some consistency to how results are processed and sets things up better for GraphBinary. Implemented for all GLVs though they do not yet have `BulkSet` implementations - they simply coerce to `List` during deserialization. This is basically what was happening before but in earlier versions it was happening on the server side.

All tests pass with `docker/build.sh -t  -i`

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1018 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] jorgebay commented on issue #1018: TINKERPOP-2111 Added BulkSet as a GraphSON Type

Posted by "jorgebay (GitHub)" <gi...@apache.org>.

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1018 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] dkuppitz commented on pull request #1018: TINKERPOP-2111 Added BulkSet as a GraphSON Type

Posted by "dkuppitz (GitHub)" <gi...@apache.org>.

The whole loop and remapping can be simplified to:

```
return Enumerable.Range(0, jArray.Count / 2).SelectMany(i =>
        Enumerable.Repeat(reader.ToObject(jArray[i * 2]), (int) reader.ToObject(jArray[i * 2 + 1]))).
    ToList();
```

[ Full content available at: https://github.com/apache/tinkerpop/pull/1018 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette closed pull request #1018: TINKERPOP-2111 Added BulkSet as a GraphSON Type

Posted by "spmallette (GitHub)" <gi...@apache.org>.

[ pull request closed by spmallette ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/1018 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on pull request #1018: TINKERPOP-2111 Added BulkSet as a GraphSON Type

Posted by "spmallette (GitHub)" <gi...@apache.org>.

nicely done. i really wanted a `partition()` function, but what you're doing there is better than that stupid for loop

[ Full content available at: https://github.com/apache/tinkerpop/pull/1018 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org