You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/28 14:54:50 UTC
[GitHub] [airflow] mik-laj opened a new pull request #14530: Use airflow db check in entrypoint_prod.sh
mik-laj opened a new pull request #14530:
URL: https://github.com/apache/airflow/pull/14530
The current health check implemented the logic of URL parsing and setting URI connection value regardless of the Airflow code, which caused compatibility issues:
* some URLs were not parsed correctly;
* some more complex configurations did not work, e.g. when the backend secret was used to store passwords, the SQLIte database was checked
* The SQLite database was not checked and due to permission issues it still might not be healthy.
To overcome these limitations, I wrote a health check that uses a built-in command - airflow db check. Now we have more confidence that the database is in good shape because we are using more code from Airflow and executing a `SELECT 1` query, which allows us to discover more connection problems.
The old code is still used for older versions of Airflow.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #14530: Use airflow db check command in entrypoint_prod.sh
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #14530:
URL: https://github.com/apache/airflow/pull/14530
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14530: Use airflow db check command in entrypoint_prod.sh
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14530:
URL: https://github.com/apache/airflow/pull/14530#issuecomment-787478287
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org