[GitHub] [pulsar] sijie commented on a change in pull request #6456: [Issue 6394] Add configuration to disable auto creation of subscriptions

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #6456: [Issue 6394] Add configuration to disable auto creation of subscriptions
URL: https://github.com/apache/pulsar/pull/6456#discussion_r386612851
 
 

 ##########
 File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java
 ##########
 @@ -104,6 +104,24 @@ public void testAutoTopicCreationDisableIfNonPartitionedTopicAlreadyExist() thro
         assertTrue(admin.namespaces().getTopics("prop/ns-abc").contains(topicName));
     }
 
+    @Test
+    public void testAutoSubscriptionCreationDisable() throws Exception{
 
 Review comment:
   @murong00 
   
   Can you add a test to cover the case - if `allowAutoSubscriptionCreation` is disabled people can still create a subscription using `pulsar-admin`? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services