You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Siddharth Srivastava (JIRA)" <ji...@apache.org> on 2011/03/12 08:55:59 UTC
[jira] Created: (DERBY-5127) Convert madhare.sql to JUnit
Convert madhare.sql to JUnit
----------------------------
Key: DERBY-5127
URL: https://issues.apache.org/jira/browse/DERBY-5127
Project: Derby
Issue Type: Improvement
Components: Test
Reporter: Siddharth Srivastava
Assignee: Siddharth Srivastava
Priority: Minor
Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017566#comment-13017566 ]
Kathey Marsden commented on DERBY-5127:
---------------------------------------
Hi Siddharth,
Thank you for the patch. I committed it at revison 1090359
One thing I wonder from the original test is about this section from the test which tests not only JDBC prepared statements but also the ij prepare and execute support;
ij> -- we do have prepare and execute support
prepare stmt as 'select i,n,t,e,g,r from s';
ij> execute stmt;
I |N |T |E |G |R
-----------------------------------------------------------------------
1 |2 |3 |4 |5 |6
10 |11 |12 |13 |14 |15
ij> -- execute can be done multiple times
execute stmt;
I wonder if the prepare and execute ij commands are tested elsewhere specifically in the tools testing. If not it should be added there.
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: Derby5127.diff, Derby5127.diff, d5127.diff, derby5127(2).diff, derby5127.diff, derby5127.diff, derby5127.diff, derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Houx Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015954#comment-13015954 ]
Houx Zhang commented on DERBY-5127:
-----------------------------------
Just some opinions:
1. Is it better to split the testBasicMadhare() into several functions, and test only one point in each function? It will make the test more readable and maintainable.
2. Why not use dropTable(String) directly to replace current st.executeUpdate( "drop table t") to keep the code clean?
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: d5127.diff, derby5127(2).diff, derby5127.diff, derby5127.diff, derby5127.diff, derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Siddharth Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008809#comment-13008809 ]
Siddharth Srivastava commented on DERBY-5127:
---------------------------------------------
While building derby(ant -quiet all), I get this error:
[javac] Note: F:\eclipsework\trunk\java\testing\org\apache\derbyTesting\functionTests\tests\jdbc4\ConnectionTest.java uses unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
May be some of the code is not compatible with java 4 ?
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Myrna van Lunteren (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren resolved DERBY-5127.
---------------------------------------
Resolution: Fixed
Fix Version/s: 10.9.0.0
I'm marking this as resolved, judging by the last communication between Kathey and Knut Anders there's nothing further needed here. Please reopen if I misread.
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Fix For: 10.9.0.0
>
> Attachments: Derby5127.diff, Derby5127.diff, d5127.diff, derby5127(2).diff, derby5127.diff, derby5127.diff, derby5127.diff, derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Siddharth Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Srivastava updated DERBY-5127:
----------------------------------------
Attachment: d5127.diff
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: d5127.diff, derby5127(2).diff, derby5127.diff, derby5127.diff, derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014722#comment-13014722 ]
Kathey Marsden commented on DERBY-5127:
---------------------------------------
I think the new patch looks fine except that the fixture throws an Exception instead of SQLException. Also the master/madhare.out (master file) needs to be removed with svn delete. I will commit with these two small changes. Normally I would say it would be good to have javadoc for each fixture but since this test just has one and there are comments in the class comments, I think that is ok. For future conversions, however make sure each fixture has javadoc.
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: d5127.diff, derby5127(2).diff, derby5127.diff, derby5127.diff, derby5127.diff, derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Siddharth Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Srivastava updated DERBY-5127:
----------------------------------------
Issue & fix info: [Newcomer, Patch Available] (was: [Newcomer])
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: derby5127(2).diff, derby5127.diff, derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Siddharth Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Srivastava updated DERBY-5127:
----------------------------------------
Attachment: derby5127.diff
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: derby5127(2).diff, derby5127.diff, derby5127.diff, derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Siddharth Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009692#comment-13009692 ]
Siddharth Srivastava commented on DERBY-5127:
---------------------------------------------
Thanks Dave for clarifying. Just tried with the latest commit by Knut (of Derby-5143) and the warning isn't there anymore :)
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014807#comment-13014807 ]
Knut Anders Hatlen commented on DERBY-5127:
-------------------------------------------
The new test executes many SQL statements, but it doesn't check the results from any of them. Is that intentional? It looks like the original test verified that the select queries returned the expected set of rows.
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: d5127.diff, derby5127(2).diff, derby5127.diff, derby5127.diff, derby5127.diff, derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Siddharth Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Srivastava updated DERBY-5127:
----------------------------------------
Attachment: Derby5127.diff
changed the diff to contain the changed code from previous commit.
The patch now conforms to 80 character a line limit
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: Derby5127.diff, Derby5127.diff, d5127.diff, derby5127(2).diff, derby5127.diff, derby5127.diff, derby5127.diff, derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Siddharth Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016877#comment-13016877 ]
Siddharth Srivastava commented on DERBY-5127:
---------------------------------------------
Thanks Knut, Kathey for pointing out the mistake.
thanks Houx for your suggestions. I too initially thought of creating separate functions but it will only compromise with the simplicity of the code (with just permutations being tested in most of the cases)
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: Derby5127.diff, d5127.diff, derby5127(2).diff, derby5127.diff, derby5127.diff, derby5127.diff, derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008823#comment-13008823 ]
Dave Brosius commented on DERBY-5127:
-------------------------------------
No, typically this is because code is casting the value coming out of some collection without checking if it really is the type expected, like
String s = (String)mycollection.get(i);
Since get() in 1.4 is declared to return java.lang.Object, the cast to String is a blind cast and 'potentially' unchecked.
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Siddharth Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Srivastava updated DERBY-5127:
----------------------------------------
Attachment: derby5127.diff
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: d5127.diff, derby5127(2).diff, derby5127.diff, derby5127.diff, derby5127.diff, derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Siddharth Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Srivastava updated DERBY-5127:
----------------------------------------
Attachment: derby5127.diff
This diff addresses the formatting issues and other issues addressed by Lily Wei and Kathey Marsden.
I have run suites.All and derbyAll. No error were caused due to this patch.
suites.All produces these 3 failures:
1) AuthenticationTest
2) ReplicationRun_Local_1Indexing
3) ReplicationRun_Local_3_p3
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: derby5127.diff, derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Siddharth Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Srivastava updated DERBY-5127:
----------------------------------------
Attachment: derby5127.diff
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017510#comment-13017510 ]
Kathey Marsden commented on DERBY-5127:
---------------------------------------
Hi Siddharth, since the test has already been committed, you should svn update and then submit a patch with just the changes. Please try to keep the lines to 80 characters.
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: Derby5127.diff, d5127.diff, derby5127(2).diff, derby5127.diff, derby5127.diff, derby5127.diff, derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018080#comment-13018080 ]
Knut Anders Hatlen commented on DERBY-5127:
-------------------------------------------
ij's prepare and execute commands are tested in tools/ij2.sql, so I think we are covered.
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: Derby5127.diff, Derby5127.diff, d5127.diff, derby5127(2).diff, derby5127.diff, derby5127.diff, derby5127.diff, derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Siddharth Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Srivastava updated DERBY-5127:
----------------------------------------
Attachment: derby5127(2).diff
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: derby5127(2).diff, derby5127.diff, derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-5127:
----------------------------------
Issue & fix info: [Newcomer] (was: [Patch Available, Newcomer])
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: Derby5127.diff, d5127.diff, derby5127(2).diff, derby5127.diff, derby5127.diff, derby5127.diff, derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015492#comment-13015492 ]
Kathey Marsden commented on DERBY-5127:
---------------------------------------
You are absolutely right. I guess I got wrapped up in the minutia in the review and missed this major point. Siddharth can you submit a new patch using org.apache.derbyTesting.junit.JDBC.assertFullResultSet() to verify the results? You can see sample usage in lang.SimpleTest and other tests.
If the ResultSet is big I sometimes use org.apache.derbyTesting.junit.showResultSet() temporarily to print out the array to feed to assertFullResultSet().
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: d5127.diff, derby5127(2).diff, derby5127.diff, derby5127.diff, derby5127.diff, derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Siddharth Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014731#comment-13014731 ]
Siddharth Srivastava commented on DERBY-5127:
---------------------------------------------
thanks Kathey. I will keep these points in mind in future patches.
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: d5127.diff, derby5127(2).diff, derby5127.diff, derby5127.diff, derby5127.diff, derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5127) Convert madhare.sql to JUnit
Posted by "Siddharth Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Srivastava updated DERBY-5127:
----------------------------------------
Attachment: Derby5127.diff
this patch adds the code to check the result set of the SQL queries tested.
> Convert madhare.sql to JUnit
> ----------------------------
>
> Key: DERBY-5127
> URL: https://issues.apache.org/jira/browse/DERBY-5127
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: Derby5127.diff, d5127.diff, derby5127(2).diff, derby5127.diff, derby5127.diff, derby5127.diff, derby5127.diff
>
>
> Convert madhare.sql to JUnit
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira