You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by biilmann <gi...@git.apache.org> on 2016/09/05 08:42:24 UTC

[GitHub] trafficserver pull request #964: Fix SSLCreateServerContext always returning...

GitHub user biilmann opened a pull request:

    https://github.com/apache/trafficserver/pull/964

    Fix SSLCreateServerContext always returning null

    This fixes TS-4769 but would like @shinrich's thoughts on whether this makes sense semantically.
    
    The fix is to let the `SSLCreateServerContext` set the `SSLCertContext::OPT_TUNNEL` option on the `sslMultCertSettings` object, which in this case makes the call to `SSLInitServerContext` do the right thing and not look for any certificates in the multicert settings object and just initialize the context. 
    
    What I'm not certain of is whether using OPT_TUNNEL for this could cause any confusion in the future...

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/biilmann/trafficserver fix-ssl-create-server-context

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/964.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #964
    
----
commit d0850c662fd192518aab2ec96332c4ab9cdb1ea5
Author: Mathias Biilmann Christensen <in...@mathias-biilmann.net>
Date:   2016-09-05T08:34:05Z

    Fix SSLCreateServerContext always returning null

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #964: Fix SSLCreateServerContext always returning null

Posted by biilmann <gi...@git.apache.org>.
Github user biilmann commented on the issue:

    https://github.com/apache/trafficserver/pull/964
  
    After some more testing this doesn't work correctly - setting `SSLCertContext::OPT_TUNNEL` does seem to have other unintended side effects.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #964: Fix SSLCreateServerContext always returning...

Posted by biilmann <gi...@git.apache.org>.
Github user biilmann closed the pull request at:

    https://github.com/apache/trafficserver/pull/964


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---