You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/06 12:17:22 UTC
[GitHub] [pulsar-client-go] wolfstudy opened a new pull request #502: Support listener name for go client
wolfstudy opened a new pull request #502:
URL: https://github.com/apache/pulsar-client-go/pull/502
Signed-off-by: xiaolongran <rx...@apache.org>
### Motivation
In PIP-61, we introduce a new feature `Advertised multiple addresses` and in Java Client, we have implemented this function. correspondingly, we should also support this function in Go client.
### Modifications
- Add listenerName filed in lookupService struct
- add test case for this feature
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy merged pull request #502: Support listener name for go client
Posted by GitBox <gi...@apache.org>.
wolfstudy merged pull request #502:
URL: https://github.com/apache/pulsar-client-go/pull/502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy commented on pull request #502: Support listener name for go client
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #502:
URL: https://github.com/apache/pulsar-client-go/pull/502#issuecomment-814077410
@freeznet PTAL thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #502: Support listener name for go client
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on a change in pull request #502:
URL: https://github.com/apache/pulsar-client-go/pull/502#discussion_r607821339
##########
File path: pulsar/internal/lookup_service.go
##########
@@ -46,21 +46,25 @@ type LookupService interface {
type lookupService struct {
rpcClient RPCClient
- serviceNameResolver ServiceNameResolver
+ serviceURL *url.URL
Review comment:
This is just to adjust the position when resolving the conflict, but not removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] zymap commented on a change in pull request #502: Support listener name for go client
Posted by GitBox <gi...@apache.org>.
zymap commented on a change in pull request #502:
URL: https://github.com/apache/pulsar-client-go/pull/502#discussion_r607810772
##########
File path: pulsar/internal/lookup_service.go
##########
@@ -46,21 +46,25 @@ type LookupService interface {
type lookupService struct {
rpcClient RPCClient
- serviceNameResolver ServiceNameResolver
+ serviceURL *url.URL
Review comment:
Why you change this? Look like we need the `ServiceNameResolver` to resolve the multiple service address.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy commented on pull request #502: Support listener name for go client
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #502:
URL: https://github.com/apache/pulsar-client-go/pull/502#issuecomment-814073859
@codelipenghui @zymap @merlimat @gaoran10 @congbobo184 PTAL thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org