[jira] [Commented] (AIRFLOW-4456) Add a base class for branching operators (akin to BranchPythonOperator)

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832379#comment-16832379 ] 

ASF GitHub Bot commented on AIRFLOW-4456:
-----------------------------------------

chronitis commented on pull request #5231: [AIRFLOW-4456] Add BranchOperator
URL: https://github.com/apache/airflow/pull/5231
 
 
   ### Jira
   
   - [x] My PR addresses https://issues.apache.org/jira/browse/AIRFLOW-4456
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   This adds an abstract BranchOperator, which implementors can use to
   create concrete operators for branching workflows fully encapsulated in
   a class, rather than needing to pass an external callable (or
   self-reference) to BranchPythonOperator. Also adds tests for same.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   `tests/operators/test_branch_operator.py`
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add a base class for branching operators (akin to BranchPythonOperator)
> -----------------------------------------------------------------------
>
>                 Key: AIRFLOW-4456
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4456
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: operators
>            Reporter: Gordon Ball
>            Priority: Major
>
> The only documented option for branching workflows is currently to use `BranchPythonOperator`, which makes sense where a simple function is to be used for branching, but is difficult to use if you want to create a reuseable operator class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)