[GitHub] davisp commented on a change in pull request #1766: Add Global timeout for map/reduce queries

[GitBox <gi...@apache.org>]

davisp commented on a change in pull request #1766: Add Global timeout for map/reduce queries
URL: https://github.com/apache/couchdb/pull/1766#discussion_r236727095
 
 

 ##########
 File path: src/fabric/src/fabric_util.erl
 ##########
 @@ -152,6 +152,13 @@ all_docs_timeout() ->
 attachments_timeout() ->
     timeout("attachments", "600000").
 
+global_view_timeout(Args) ->
+    PartitionQuery = couch_mrview_util:get_extra(Args, partition, false),
+    case PartitionQuery of
+        false -> timeout("global_view_timeout", "infinity");
 
 Review comment:
   You're doubling up the _timeout suffix cause the timeout/2 call appends that as well. Also global_view_timeout should probably be shortened to just view_timeout because you're looking at global vs partitioned. Also global_partition is a bit of a misnomer and should just be partition_view_timeout.
   
   Also I think the SOP is to add commented out config options with their default values in default.ini. If the other timeout config options aren't already present I'd add all five settings in a separate commit on this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services