You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/08/16 23:18:00 UTC
Review Request 37510: Add more logging to the scheduler library
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37510/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
Trivial change involving adding more logging to the scheduler library while sending/receiving events.
Diffs
-----
src/scheduler/scheduler.cpp 0aef68e3a43eaee830880fb31543c7ed7c67769a
Diff: https://reviews.apache.org/r/37510/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 37510: Add more logging to the scheduler library
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37510/#review95551
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 16, 2015, 9:18 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37510/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2015, 9:18 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Trivial change involving adding more logging to the scheduler library while sending/receiving events.
>
>
> Diffs
> -----
>
> src/scheduler/scheduler.cpp 0aef68e3a43eaee830880fb31543c7ed7c67769a
>
> Diff: https://reviews.apache.org/r/37510/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 37510: Add more logging to the scheduler library
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37510/#review95563
-----------------------------------------------------------
Bad patch!
Reviews applied: [37510]
Failed command: ./support/apply-review.sh -n -r 37510
Error:
2015-08-17 05:22:06 URL:https://reviews.apache.org/r/37510/diff/raw/ [1013/1013] -> "37510.patch" [1]
error: patch failed: src/scheduler/scheduler.cpp:300
error: src/scheduler/scheduler.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Aug. 16, 2015, 9:18 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37510/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2015, 9:18 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Trivial change involving adding more logging to the scheduler library while sending/receiving events.
>
>
> Diffs
> -----
>
> src/scheduler/scheduler.cpp 0aef68e3a43eaee830880fb31543c7ed7c67769a
>
> Diff: https://reviews.apache.org/r/37510/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 37510: Add more logging to the scheduler library
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37510/#review95554
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 八月 16, 2015, 9:18 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37510/
> -----------------------------------------------------------
>
> (Updated 八月 16, 2015, 9:18 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Trivial change involving adding more logging to the scheduler library while sending/receiving events.
>
>
> Diffs
> -----
>
> src/scheduler/scheduler.cpp 0aef68e3a43eaee830880fb31543c7ed7c67769a
>
> Diff: https://reviews.apache.org/r/37510/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>