You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by jasdeep-hundal <no...@github.com> on 2014/03/26 00:51:47 UTC
[jclouds] JCLOUDS-515: Don't require availability zone when creating
volumes in cinder (#327)
Fixes: https://issues.apache.org/jira/browse/JCLOUDS-515
You can merge this Pull Request by running:
git pull https://github.com/jasdeep-hundal/jclouds no_require_avail_zone_cinder
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/327
-- Commit Summary --
* JCLOUDS-515: Don't require availability zone when creating volumes in cinder
-- File Changes --
M apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/domain/Volume.java (2)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/327.patch
https://github.com/jclouds/jclouds/pull/327.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327
Re: [jclouds] JCLOUDS-515: Don't require availability zone when
creating volumes in cinder (#327)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #956](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/956/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38728902
Re: [jclouds] JCLOUDS-515: Don't require availability zone when
creating volumes in cinder (#327)
Posted by jasdeep-hundal <no...@github.com>.
Thanks @everett-toews , I was a little quick to jump the gun there. Left a comment in the ticket, but there is a fix that needs to be made, not sure if it is this one though.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38746123
Re: [jclouds] JCLOUDS-515: Don't require availability zone when
creating volumes in cinder (#327)
Posted by Everett Toews <no...@github.com>.
@jasdeep-hundal @nacx I made [a comment](https://issues.apache.org/jira/browse/JCLOUDS-515?focusedCommentId=13948419&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13948419) that was more appropriate to be made over in the issue.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38736206
Re: [jclouds] JCLOUDS-515: Don't require availability zone when
creating volumes in cinder (#327)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #694](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/694/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38639405
Re: [jclouds] JCLOUDS-515: Don't require availability zone when
creating volumes in cinder (#327)
Posted by Everett Toews <no...@github.com>.
Closed #327.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327
Re: [jclouds] JCLOUDS-515: Don't require availability zone when
creating volumes in cinder (#327)
Posted by Andrew Phillips <no...@github.com>.
Thanks, @jasdeep-hundal and @everett-toews!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-39198738
Re: [jclouds] JCLOUDS-515: Don't require availability zone when
creating volumes in cinder (#327)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1174](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1174/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38764380
Re: [jclouds] JCLOUDS-515: Don't require availability zone when
creating volumes in cinder (#327)
Posted by Andrew Phillips <no...@github.com>.
> I made a comment that was more appropriate to be made over in the issue.
Good catch, @everett-toews. Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38738453
Re: [jclouds] JCLOUDS-515: Don't require availability zone when
creating volumes in cinder (#327)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #701](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/701/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38727091
Re: [jclouds] JCLOUDS-515: Don't require availability zone when
creating volumes in cinder (#327)
Posted by Ignasi Barrera <no...@github.com>.
Could you add a live test to the `VolumeAndSnapshotApiLiveTest` to assert that volumes can actually be created without the AZ?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38656429
Re: [jclouds] JCLOUDS-515: Don't require availability zone when
creating volumes in cinder (#327)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1164](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1164/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38639908
Re: [jclouds] JCLOUDS-515: Don't require availability zone when
creating volumes in cinder (#327)
Posted by Everett Toews <no...@github.com>.
+1
I'm okay with this. I suspect the value is set that way because of a driver in Cinder. I could see this being the case for other Cinder driver's as well.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-39128245
Re: [jclouds] JCLOUDS-515: Don't require availability zone when
creating volumes in cinder (#327)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #704](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/704/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38764216
Re: [jclouds] JCLOUDS-515: Don't require availability zone when
creating volumes in cinder (#327)
Posted by jasdeep-hundal <no...@github.com>.
@nacx : I removed the zone specification from the test and it passed, so I think this is good to go. Could add another test to use zone as well, but I'm not sure how valuable an additional test just for that will be.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38735446
Re: [jclouds] JCLOUDS-515: Don't require availability zone when
creating volumes in cinder (#327)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #950](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/950/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38638975
Re: [jclouds] JCLOUDS-515: Don't require availability zone when
creating volumes in cinder (#327)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #960](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/960/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38763497
Re: [jclouds] JCLOUDS-515: Don't require availability zone when
creating volumes in cinder (#327)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1171](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1171/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38727828
Re: [jclouds] JCLOUDS-515: Don't require availability zone when
creating volumes in cinder (#327)
Posted by Everett Toews <no...@github.com>.
Merged to master and 1.7.x.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-39129202
Re: [jclouds] JCLOUDS-515: Don't require availability zone when
creating volumes in cinder (#327)
Posted by Ignasi Barrera <no...@github.com>.
Yep, I see now (and agree). Thx @everett-toews !
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38744957