You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by dcelasun <gi...@git.apache.org> on 2017/10/02 07:10:00 UTC
[GitHub] thrift pull request #1381: THRIFT-4285: Move TX/RX methods from gen. code to...
GitHub user dcelasun opened a pull request:
https://github.com/apache/thrift/pull/1381
THRIFT-4285: Move TX/RX methods from gen. code to library
This change removes a lot of duplication from generated code and allows the caller to customize how they can read from / write to the transport.
This patch was originally written by [Chris Bannister](https://issues.apache.org/jira/browse/THRIFT-4285) but it seemed abandoned and no longer applied cleanly to master. I fixed it in order to get things moving again.
It would be great if we can get this in before 0.11 is tagged.
Client: Go
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dcelasun/thrift THRIFT-4285
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1381.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1381
----
commit 0e03968520db377bce9f85caf55d7a218f9d59d5
Author: D. Can Celasun <ca...@dcc.im>
Date: 2017-09-21T13:21:00Z
THRIFT-4285 Move TX/RX methods from gen. code to library
This change removes a lot of duplication from generated code and allows
the caller to customize how they can read from / write to the
transport.
Client: Go
----
---
[GitHub] thrift pull request #1381: THRIFT-4285: Move TX/RX methods from gen. code to...
Posted by dcelasun <gi...@git.apache.org>.
Github user dcelasun closed the pull request at:
https://github.com/apache/thrift/pull/1381
---