You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/14 04:22:45 UTC
[GitHub] [spark] dongjoon-hyun commented on pull request #38589: [SPARK-41087][BUILD] Remove duplicate `-Xmx4g` from `dev/make-distribution.sh` and make `build/mvn` use the same JAVA_OPTS
dongjoon-hyun commented on PR #38589:
URL: https://github.com/apache/spark/pull/38589#issuecomment-1313078598
BTW, @LuciferYang . Did you run the full Maven testing with this configuration? `dev/make-distribution.sh` is simply for building while `build/mvn` should support testing. Please run a full testing to verify your PR doesn't break anything in Maven testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org