[GitHub] mistercrunch opened a new pull request #4316: Fix caching issues

[GitBox <gi...@apache.org>]

mistercrunch opened a new pull request #4316: Fix caching issues
URL: https://github.com/apache/incubator-superset/pull/4316
 
 
   Moving to cache the output of the dataframe as opposed to the output of `get_data`. Caching the output of `get_data` doesn't work if the basis for the `cache_key` is the "query object". When changing controls like the moving average configuration, this doesn't affect the query object (same cache key), but it does affect the post processing that append in `get_data`. If we use the query object as the basis for the cache key, we need to cache the dataframe itself, and re-execute get_data against the cache.
   
   This may not be 100% ready for merging as:
   * I'm unclear on whether the serialization of the dataframe (using df.to_dict) is 100% clean, there could be bugs where some things get lost through the serde process
   * FilterBox doesn't get cached anymore as it doesn't follow the common pattern of using `get_df
   
   @john-bodley 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services