[GitHub] [skywalking] wu-sheng commented on a change in pull request #7526: Kafka extra producer configuration enhancement

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #7526:
URL: https://github.com/apache/skywalking/pull/7526#discussion_r693345122



##########
File path: docs/en/setup/service-agent/java-agent/How-to-enable-kafka-reporter.md
##########
@@ -12,8 +12,10 @@ collector.backend_service=${SW_AGENT_COLLECTOR_BACKEND_SERVICES:127.0.0.1:11800}
 
 # Kafka producer configuration
 plugin.kafka.bootstrap_servers=${SW_KAFKA_BOOTSTRAP_SERVERS:localhost:9092}
-plugin.kafka.producer_config[delivery.timeout.ms]=12000
 plugin.kafka.get_topic_timeout=${SW_GET_TOPIC_TIMEOUT:10}
+
+# Configure extra Kafka Producer configuration
+plugin.kafka.producer_config[delivery.timeout.ms]=12000

Review comment:
       I think comments in the `KafkaReporterPluginConfig` should be a separate section in this doc. 
   It is better to remove `plugin.kafka.producer_config[delivery.timeout.ms]=12000` from here.
   
   Adding `Advanced Kafka Configs` maybe better




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org