You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/06 03:09:38 UTC

[GitHub] [apisix-dashboard] dmsolr opened a new pull request #1839: chore: update plugin catagory display name.

dmsolr opened a new pull request #1839:
URL: https://github.com/apache/apisix-dashboard/pull/1839


   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   I found this name is "可观测" in chinese. So I think `Observability` is better than "Tracing & Metrics & Logging". 
   
   
   **Why submit this pull request?**
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   Please update this section with detailed description.
   
   **Related issues**
   
   fix/resolve #0001
   
   **Checklist:**
   
   - [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   - [ ] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1839: chore: update plugin catagory display name.

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1839:
URL: https://github.com/apache/apisix-dashboard/pull/1839#issuecomment-833489007


   @dmsolr Please update your PR's description :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1839: chore: update plugin catagory display name.

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #1839:
URL: https://github.com/apache/apisix-dashboard/pull/1839#discussion_r627054451



##########
File path: web/src/components/Plugin/locales/en-US.ts
##########
@@ -27,7 +27,7 @@ export default {
   'component.plugin.security': 'Security',
   'component.plugin.traffic': 'Traffic Control',
   'component.plugin.serverless': 'Serverless',
-  'component.plugin.observability': 'Tracing & Metrics & Logging',
+  'component.plugin.observability': 'Observability',

Review comment:
       Don't you think, 
   'Tracing & Metrics & Logging' -  gives a more clear idea
   Just asking




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Yiyiyimu merged pull request #1839: chore: update plugin catagory display name.

Posted by GitBox <gi...@apache.org>.
Yiyiyimu merged pull request #1839:
URL: https://github.com/apache/apisix-dashboard/pull/1839


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1839: chore: update plugin catagory display name.

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1839:
URL: https://github.com/apache/apisix-dashboard/pull/1839#issuecomment-833197021


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1839?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1839](https://codecov.io/gh/apache/apisix-dashboard/pull/1839?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d2a2fa8) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/16dfb4d669b4cb6eecc38a3bee92067938dc5ccb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (16dfb4d) will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1839/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1839?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1839      +/-   ##
   ==========================================
   + Coverage   72.07%   72.10%   +0.02%     
   ==========================================
     Files         125      125              
     Lines        2944     2947       +3     
     Branches      710      711       +1     
   ==========================================
   + Hits         2122     2125       +3     
     Misses        822      822              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `72.10% <ø> (+0.02%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1839?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/pages/Route/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1839/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9DcmVhdGUudHN4) | `90.99% <0.00%> (+0.25%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1839?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1839?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [16dfb4d...d2a2fa8](https://codecov.io/gh/apache/apisix-dashboard/pull/1839?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1839: chore: update plugin catagory display name.

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #1839:
URL: https://github.com/apache/apisix-dashboard/pull/1839#discussion_r627054451



##########
File path: web/src/components/Plugin/locales/en-US.ts
##########
@@ -27,7 +27,7 @@ export default {
   'component.plugin.security': 'Security',
   'component.plugin.traffic': 'Traffic Control',
   'component.plugin.serverless': 'Serverless',
-  'component.plugin.observability': 'Tracing & Metrics & Logging',
+  'component.plugin.observability': 'Observability',

Review comment:
       Don't you think, 
   'Tracing & Metrics & Logging' -  gives a more clear idea




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1839: chore: update plugin catagory display name.

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1839:
URL: https://github.com/apache/apisix-dashboard/pull/1839#issuecomment-833191512


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit d2a2fa8ceab93a3949245153a50b926f4b75a839
   
   https://deploy-preview-1839--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1839: chore: update plugin catagory display name.

Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1839:
URL: https://github.com/apache/apisix-dashboard/pull/1839#issuecomment-833191512


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit d2a2fa8ceab93a3949245153a50b926f4b75a839
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/60935de76bb80a00074d7cf0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1839: chore: update plugin catagory display name.

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1839:
URL: https://github.com/apache/apisix-dashboard/pull/1839#discussion_r630045984



##########
File path: web/src/components/Plugin/locales/en-US.ts
##########
@@ -27,7 +27,7 @@ export default {
   'component.plugin.security': 'Security',
   'component.plugin.traffic': 'Traffic Control',
   'component.plugin.serverless': 'Serverless',
-  'component.plugin.observability': 'Tracing & Metrics & Logging',
+  'component.plugin.observability': 'Observability',

Review comment:
       `Observability` would be more professional for me, and as a category, I agree to make it more professional but shoter. How about others?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org