[Bug 4420] If a rule has no score, _handle_hit() blows up

[bu...@bugzilla.spamassassin.org]

http://bugzilla.spamassassin.org/show_bug.cgi?id=4420





------- Additional Comments From felicity@apache.org  2005-06-22 09:07 -------
Subject: Re:   New: If a rule has no score, _handle_hit() blows up

On Wed, Jun 22, 2005 at 07:49:34AM -0700, bugzilla-daemon@bugzilla.spamassassin.org wrote:
> I'm not sure if this is a case of "well, just make sure your rules have scores"
> or if SA should be updated to gracefully warn or otherwise handle it.

IMO, that's pretty much it.  The Conf system makes sure all rules have a score
before anything gets processed, so the case of a rule w/ no score should never
occur.  

> If a rule hits but has no score, PerMsgStatus::handle_hit() passes an undefined
> $score to _handle_hit(), which blows up attempting to use it as a number,
> generating about 20 "Use of uninitialized value in..." errors.

It probably shouldn't do that anyway, but I also don't like checking for cases
that should never happen because of checking earlier in the code.





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.