You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by sh...@apache.org on 2021/04/07 10:30:55 UTC

[echarts] 01/01: style: remove unused imports. fix imports from entry

This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch fix-linting
in repository https://gitbox.apache.org/repos/asf/echarts.git

commit 11eb4fc804f29a7ee1843a4ffb12bcfbb7802471
Author: pissang <bm...@gmail.com>
AuthorDate: Wed Apr 7 18:28:52 2021 +0800

    style: remove unused imports. fix imports from entry
---
 src/component/graphic/install.ts    |  1 -
 src/component/legend/LegendModel.ts |  4 ----
 src/component/legend/LegendView.ts  | 21 ++++++++++++++++++---
 src/model/Series.ts                 |  1 -
 test/runTest/client/index.html      |  2 +-
 5 files changed, 19 insertions(+), 10 deletions(-)

diff --git a/src/component/graphic/install.ts b/src/component/graphic/install.ts
index bda54f3..61ed438 100644
--- a/src/component/graphic/install.ts
+++ b/src/component/graphic/install.ts
@@ -45,7 +45,6 @@ import { getECData } from '../../util/innerStore';
 import { TextStyleProps } from 'zrender/src/graphic/Text';
 import { isEC4CompatibleStyle, convertFromEC4CompatibleStyle } from '../../util/styleCompat';
 import { EChartsExtensionInstallRegisters } from '../../extension';
-import { graphic } from '../../export/api';
 
 const TRANSFORM_PROPS = {
     x: 1,
diff --git a/src/component/legend/LegendModel.ts b/src/component/legend/LegendModel.ts
index ca5e094..ccf5ba8 100644
--- a/src/component/legend/LegendModel.ts
+++ b/src/component/legend/LegendModel.ts
@@ -29,9 +29,6 @@ import {
     LabelOption,
     LayoutOrient,
     CommonTooltipOption,
-    ZRColor,
-    DecalObject,
-    ZRLineType,
     ItemStyleOption,
     LineStyleOption
 } from '../../util/types';
@@ -39,7 +36,6 @@ import { Dictionary } from 'zrender/src/core/types';
 import GlobalModel from '../../model/Global';
 import { ItemStyleProps } from '../../model/mixin/itemStyle';
 import { LineStyleProps } from './../../model/mixin/lineStyle';
-import {SeriesModel} from '../../echarts';
 import {PathStyleProps} from 'zrender/src/graphic/Path';
 
 type LegendDefaultSelectorOptionsProps = {
diff --git a/src/component/legend/LegendView.ts b/src/component/legend/LegendView.ts
index 8b0a775..7d7cab4 100644
--- a/src/component/legend/LegendView.ts
+++ b/src/component/legend/LegendView.ts
@@ -27,7 +27,14 @@ import {setLabelStyle, createTextStyle} from '../../label/labelStyle';
 import {makeBackground} from '../helper/listComponent';
 import * as layoutUtil from '../../util/layout';
 import ComponentView from '../../view/Component';
-import LegendModel, { LegendItemStyleOption, LegendLineStyleOption, LegendOption, LegendSelectorButtonOption, LegendSymbolParams, LegendTooltipFormatterParams } from './LegendModel';
+import LegendModel, {
+    LegendItemStyleOption,
+    LegendLineStyleOption,
+    LegendOption,
+    LegendSelectorButtonOption,
+    LegendSymbolParams,
+    LegendTooltipFormatterParams
+} from './LegendModel';
 import GlobalModel from '../../model/Global';
 import ExtensionAPI from '../../core/ExtensionAPI';
 import {
@@ -39,10 +46,10 @@ import {
     SymbolOptionMixin
 } from '../../util/types';
 import Model from '../../model/Model';
-import {SeriesModel} from '../../echarts';
 import {LineStyleProps, LINE_STYLE_KEY_MAP} from '../../model/mixin/lineStyle';
 import {ITEM_STYLE_KEY_MAP} from '../../model/mixin/itemStyle';
 import {createSymbol, ECSymbol} from '../../util/symbol';
+import SeriesModel from '../../model/Series';
 
 const curry = zrUtil.curry;
 const each = zrUtil.each;
@@ -347,7 +354,15 @@ class LegendView extends ComponentView {
         symbolType = legendIconType || symbolType || 'roundRect';
 
         const legendLineStyle = legendModel.getModel('lineStyle');
-        const style = getLegendStyle(symbolType, itemModel, legendLineStyle, lineVisualStyle, itemVisualStyle, drawType, isSelected);
+        const style = getLegendStyle(
+            symbolType,
+            itemModel,
+            legendLineStyle,
+            lineVisualStyle,
+            itemVisualStyle,
+            drawType,
+            isSelected
+        );
 
         const itemGroup = new Group();
 
diff --git a/src/model/Series.ts b/src/model/Series.ts
index 2056c39..8e90bf3 100644
--- a/src/model/Series.ts
+++ b/src/model/Series.ts
@@ -20,7 +20,6 @@
 import * as zrUtil from 'zrender/src/core/util';
 import env from 'zrender/src/core/env';
 import type {MorphDividingMethod} from 'zrender/src/tool/morphPath';
-import {PathStyleProps} from 'zrender/src/graphic/Path';
 import * as modelUtil from '../util/model';
 import {
     DataHost, DimensionName, StageHandlerProgressParams,
diff --git a/test/runTest/client/index.html b/test/runTest/client/index.html
index 2d94b97..d58bd83 100644
--- a/test/runTest/client/index.html
+++ b/test/runTest/client/index.html
@@ -24,7 +24,7 @@ under the License.
     <meta charset="UTF-8">
     <meta name="viewport" content="width=device-width, initial-scale=1.0">
     <meta http-equiv="X-UA-Compatible" content="ie=edge">
-    <link rel="shortcut icon" href="https://www.echartsjs.com/zh/images/favicon.png">
+    <link rel="shortcut icon" href="https://echarts.apache.org/zh/images/favicon.png">
     <title>Visual Regression Testing Tool</title>
 </head>
 <body>

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org