You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/11 08:43:34 UTC
[GitHub] [flink] gaborgsomogyi opened a new pull request, #21294: [FLINK-29704][runtime][security] E2E test for delegation token framework
gaborgsomogyi opened a new pull request, #21294:
URL: https://github.com/apache/flink/pull/21294
## What is the purpose of the change
At the moment there is no e2e test which would test whether delegation token is working fine. In this PR I've added it.
## Brief change log
Added e2e delegation token framework test.
## Verifying this change
Existing e2e tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mbalassi merged pull request #21294: [FLINK-29704][runtime][security] E2E test for delegation token framework
Posted by GitBox <gi...@apache.org>.
mbalassi merged PR #21294:
URL: https://github.com/apache/flink/pull/21294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #21294: [FLINK-29704][runtime][security] E2E test for delegation token framework
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21294:
URL: https://github.com/apache/flink/pull/21294#issuecomment-1314299877
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #21294: [FLINK-29704][runtime][security] E2E test for delegation token framework
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21294:
URL: https://github.com/apache/flink/pull/21294#issuecomment-1311822976
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21294: [FLINK-29704][runtime][security] E2E test for delegation token framework
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21294:
URL: https://github.com/apache/flink/pull/21294#issuecomment-1311407970
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c16cfff221d832f5e6394a8b595926285d08f1bc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c16cfff221d832f5e6394a8b595926285d08f1bc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c16cfff221d832f5e6394a8b595926285d08f1bc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #21294: [FLINK-29704][runtime][security] E2E test for delegation token framework
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21294:
URL: https://github.com/apache/flink/pull/21294#issuecomment-1314299718
Pulsar test flaky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #21294: [FLINK-29704][runtime][security] E2E test for delegation token framework
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on code in PR #21294:
URL: https://github.com/apache/flink/pull/21294#discussion_r1022432629
##########
flink-runtime/src/main/java/org/apache/flink/runtime/security/token/DelegationTokenUpdater.java:
##########
@@ -38,18 +38,18 @@ public static void addCurrentUserCredentials(byte[] credentialsBytes) throws IOE
throw new IllegalArgumentException("Illegal credentials tried to be set");
}
Credentials credentials = DelegationTokenConverter.deserialize(credentialsBytes);
- LOG.debug("Updating delegation tokens for current user");
+ LOG.info("Updating delegation tokens for current user");
Review Comment:
My main intention is to see token usage in info level. These logs are produced small amount of logs (maybe 10-20 line per day) but they're essential to see the token framework full lifecycle. As a side effect I'm using one of them as assertion criteria.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #21294: [FLINK-29704][runtime][security] E2E test for delegation token framework
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on code in PR #21294:
URL: https://github.com/apache/flink/pull/21294#discussion_r1022432629
##########
flink-runtime/src/main/java/org/apache/flink/runtime/security/token/DelegationTokenUpdater.java:
##########
@@ -38,18 +38,18 @@ public static void addCurrentUserCredentials(byte[] credentialsBytes) throws IOE
throw new IllegalArgumentException("Illegal credentials tried to be set");
}
Credentials credentials = DelegationTokenConverter.deserialize(credentialsBytes);
- LOG.debug("Updating delegation tokens for current user");
+ LOG.info("Updating delegation tokens for current user");
Review Comment:
My main intention is to see token usage in info level. These logs are produced small amount of logs (maybe 10-20 line per day) but they're essential to see the tkoen framework lifecycle. As a side effect I'm using one of them as assertion criteria.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #21294: [FLINK-29704][runtime][security] E2E test for delegation token framework
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21294:
URL: https://github.com/apache/flink/pull/21294#issuecomment-1312584460
cc @mbalassi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #21294: [FLINK-29704][runtime][security] E2E test for delegation token framework
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21294:
URL: https://github.com/apache/flink/pull/21294#issuecomment-1314021449
Rebased to the latest master in order to see that it works even if old DT framework deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mbalassi commented on a diff in pull request #21294: [FLINK-29704][runtime][security] E2E test for delegation token framework
Posted by GitBox <gi...@apache.org>.
mbalassi commented on code in PR #21294:
URL: https://github.com/apache/flink/pull/21294#discussion_r1021992440
##########
flink-runtime/src/main/java/org/apache/flink/runtime/security/token/DelegationTokenUpdater.java:
##########
@@ -38,18 +38,18 @@ public static void addCurrentUserCredentials(byte[] credentialsBytes) throws IOE
throw new IllegalArgumentException("Illegal credentials tried to be set");
}
Credentials credentials = DelegationTokenConverter.deserialize(credentialsBytes);
- LOG.debug("Updating delegation tokens for current user");
+ LOG.info("Updating delegation tokens for current user");
Review Comment:
@gaborgsomogyi are you changing the log level because you reconsidered the usefulness of these messages or just to help with testing? If the latter is true we should instead set the log config to be debug level in the e2e test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #21294: [FLINK-29704][runtime][security] E2E test for delegation token framework
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21294:
URL: https://github.com/apache/flink/pull/21294#issuecomment-1311408008
I was not able to make the e2e tests work on my local machine (doc states the same that it's not designed for local development) so first checking whether it works or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org