You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Charlie Carson <ch...@gmail.com> on 2014/02/26 23:14:24 UTC
Review Request 18540: assign bool directly to JSON::Value
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18540/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
assign bool directly to JSON::Value
This change removes the workaround that was necessary now that
https://issues.apache.org/jira/browse/MESOS-939 is committed.
Review: https://reviews.apache.org/r/18540
Diffs
-----
src/master/http.cpp e64093c2aa9d54ad615050ed0339ab0d6d4c6e41
src/tests/repair_tests.cpp ba6f50ad67ebe834ae4af5fc10bd39270ce91471
Diff: https://reviews.apache.org/r/18540/diff/
Testing
-------
make check
Thanks,
Charlie Carson
Re: Review Request 18540: assign bool directly to JSON::Value
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18540/#review35571
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On Feb. 26, 2014, 2:14 p.m., Charlie Carson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18540/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2014, 2:14 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> assign bool directly to JSON::Value
>
> This change removes the workaround that was necessary now that
> https://issues.apache.org/jira/browse/MESOS-939 is committed.
>
> Review: https://reviews.apache.org/r/18540
>
>
> Diffs
> -----
>
> src/master/http.cpp e64093c2aa9d54ad615050ed0339ab0d6d4c6e41
> src/tests/repair_tests.cpp ba6f50ad67ebe834ae4af5fc10bd39270ce91471
>
> Diff: https://reviews.apache.org/r/18540/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Charlie Carson
>
>
Re: Review Request 18540: assign bool directly to JSON::Value
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18540/#review35642
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Feb. 26, 2014, 10:14 p.m., Charlie Carson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18540/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2014, 10:14 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> assign bool directly to JSON::Value
>
> This change removes the workaround that was necessary now that
> https://issues.apache.org/jira/browse/MESOS-939 is committed.
>
> Review: https://reviews.apache.org/r/18540
>
>
> Diffs
> -----
>
> src/master/http.cpp e64093c2aa9d54ad615050ed0339ab0d6d4c6e41
> src/tests/repair_tests.cpp ba6f50ad67ebe834ae4af5fc10bd39270ce91471
>
> Diff: https://reviews.apache.org/r/18540/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Charlie Carson
>
>