You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/07/05 12:20:36 UTC

[GitHub] [cloudstack] shwstppr opened a new pull request #5181: vmware, ui: update portgroup on network offering change

shwstppr opened a new pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181


   ### Description
   
   On network offering change VMware portgroup should be updated accordingly
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-887185687


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 658


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-891846794


   @shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#discussion_r709952092



##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -4042,16 +4042,6 @@ private NicProfile orchestrateAddVmToNetwork(final VirtualMachine vm, final Netw
             //3) Convert nicProfile to NicTO
             final NicTO nicTO = toNicTO(nic, vmProfile.getVirtualMachine().getHypervisorType());
 
-            if (network != null) {
-                final Map<NetworkOffering.Detail, String> details = networkOfferingDetailsDao.getNtwkOffDetails(network.getNetworkOfferingId());
-                if (details != null) {
-                    details.putIfAbsent(NetworkOffering.Detail.PromiscuousMode, NetworkOrchestrationService.PromiscuousMode.value().toString());
-                    details.putIfAbsent(NetworkOffering.Detail.MacAddressChanges, NetworkOrchestrationService.MacAddressChanges.value().toString());
-                    details.putIfAbsent(NetworkOffering.Detail.ForgedTransmits, NetworkOrchestrationService.ForgedTransmits.value().toString());
-                }
-                nicTO.setDetails(details);
-            }

Review comment:
       @shwstppr are these details settings moved to Network Orchestration (when setting Nic profile there), right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921728116


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1305


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-922132868


   <b>Trillian test result (tid-2112)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 40934 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5181-t2112-vmware-67u3.zip
   Smoke tests completed. 89 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-916364611


   <b>Trillian Build Failed (tid-2006)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-892570753






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-887185687


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 658


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-914965835


   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1167


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893859916


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-889664858


   <b>Trillian test result (tid-1407)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 74200 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5181-t1407-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 84 look OK, 5 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 616.48 | test_internal_lb.py
   test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 3604.78 | test_kubernetes_clusters.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 3604.01 | test_kubernetes_clusters.py
   test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 49.44 | test_kubernetes_clusters.py
   ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 699.65 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 619.48 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 559.52 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 559.53 | test_vpc_redundant.py
   test_01_redundant_vpc_site2site_vpn | `Error` | 447.05 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893429662


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893360948


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-891845344


   @shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-888156845


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#discussion_r709953075



##########
File path: server/src/main/java/com/cloud/hypervisor/HypervisorGuruBase.java
##########
@@ -97,6 +98,25 @@
     public static ConfigKey<Boolean> VmMinCpuSpeedEqualsCpuSpeedDividedByCpuOverprovisioningFactor = new ConfigKey<Boolean>("Advanced", Boolean.class, "vm.min.cpu.speed.equals.cpu.speed.divided.by.cpu.overprovisioning.factor", "true",
             "If we set this to 'true', a minimum CPU speed (cpu speed/ cpu.overprovisioning.factor) will be set on the VM, independent of using a scalable service offering or not.", true, ConfigKey.Scope.Cluster);
 
+    private Map<NetworkOffering.Detail, String> getNicDetails(Network network) {
+        if (network == null) {
+            s_logger.debug("Unable to get NIC details as the network is null");
+            return null;
+        }
+        Map<NetworkOffering.Detail, String> details = networkOfferingDetailsDao.getNtwkOffDetails(network.getNetworkOfferingId());
+        if (details != null) {
+            details.putIfAbsent(NetworkOffering.Detail.PromiscuousMode, NetworkOrchestrationService.PromiscuousMode.value().toString());
+            details.putIfAbsent(NetworkOffering.Detail.MacAddressChanges, NetworkOrchestrationService.MacAddressChanges.value().toString());
+            details.putIfAbsent(NetworkOffering.Detail.ForgedTransmits, NetworkOrchestrationService.ForgedTransmits.value().toString());
+            details.putIfAbsent(NetworkOffering.Detail.MacLearning, NetworkOrchestrationService.MacLearning.value().toString());

Review comment:
       Are these details set for nics of VMs on VMware hypervisor only?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-915028822


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1172


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921580698


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#discussion_r709969391



##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -4042,16 +4042,6 @@ private NicProfile orchestrateAddVmToNetwork(final VirtualMachine vm, final Netw
             //3) Convert nicProfile to NicTO
             final NicTO nicTO = toNicTO(nic, vmProfile.getVirtualMachine().getHypervisorType());
 
-            if (network != null) {
-                final Map<NetworkOffering.Detail, String> details = networkOfferingDetailsDao.getNtwkOffDetails(network.getNetworkOfferingId());
-                if (details != null) {
-                    details.putIfAbsent(NetworkOffering.Detail.PromiscuousMode, NetworkOrchestrationService.PromiscuousMode.value().toString());
-                    details.putIfAbsent(NetworkOffering.Detail.MacAddressChanges, NetworkOrchestrationService.MacAddressChanges.value().toString());
-                    details.putIfAbsent(NetworkOffering.Detail.ForgedTransmits, NetworkOrchestrationService.ForgedTransmits.value().toString());
-                }
-                nicTO.setDetails(details);
-            }

Review comment:
       @sureshanaparti moved to HypervisorGuruBase. The method at line 4043 was calling `HypervisorBaseGuru::toNicTO` and then setting these details. Since `HypervisorBaseGuru::toNicTO` has been refactored to include this code setting these details again was not needed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-891811033


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893800570


   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian. SL-JID 769


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921671450


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1300


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-914993681


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893800570






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-915763885


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#discussion_r689689836



##########
File path: server/src/main/java/com/cloud/hypervisor/HypervisorGuruBase.java
##########
@@ -97,6 +98,24 @@
     public static ConfigKey<Boolean> VmMinCpuSpeedEqualsCpuSpeedDividedByCpuOverprovisioningFactor = new ConfigKey<Boolean>("Advanced", Boolean.class, "vm.min.cpu.speed.equals.cpu.speed.divided.by.cpu.overprovisioning.factor", "true",
             "If we set this to 'true', a minimum CPU speed (cpu speed/ cpu.overprovisioning.factor) will be set on the VM, independent of using a scalable service offering or not.", true, ConfigKey.Scope.Cluster);
 
+    private Map<NetworkOffering.Detail, String> getNicDetails(Network network) {
+        Map<NetworkOffering.Detail, String> details = null;
+        if (network != null) {

Review comment:
       We could invert this if to reduce indentation and maybe add a log.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-916629437


   <b>Trillian test result (tid-2007)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33707 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5181-t2007-kvm-centos7.zip
   Smoke tests completed. 89 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-915763137


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893397087


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 763


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] SadiJr commented on a change in pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
SadiJr commented on a change in pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#discussion_r679106288



##########
File path: ui/src/views/AutogenView.vue
##########
@@ -834,6 +834,10 @@ export default {
         params.isofilter = 'executable'
       } else if (possibleApi === 'listHosts') {
         params.type = 'routing'
+      } else if (possibleApi === 'listNetworkOfferings') {
+        if (this.resource && this.resource.type) {

Review comment:
       @shwstppr :+1:




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] SadiJr commented on a change in pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
SadiJr commented on a change in pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#discussion_r670468794



##########
File path: ui/src/views/AutogenView.vue
##########
@@ -834,6 +834,10 @@ export default {
         params.isofilter = 'executable'
       } else if (possibleApi === 'listHosts') {
         params.type = 'routing'
+      } else if (possibleApi === 'listNetworkOfferings') {
+        if (this.resource && this.resource.type) {

Review comment:
       Wouldn't it be better to add this if to the else statement?
   Like
   ```
   } else if (possibleApi === 'listNetworkOfferings' && (this.resource && this.resource.type)) {
      params.guestiptype = this.resource.type
   }
   ```
   
   Or
   ```
   } else if (possibleApi === 'listNetworkOfferings' && this.resource && this.resource.type) {
      params.guestiptype = this.resource.type
   }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-914965835






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-915763470


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr closed pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-892583859


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 751


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-892570753


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-894428644


   <b>Trillian test result (tid-1505)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 42296 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5181-t1505-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 89 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893277978


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921579315






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893294629


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 759


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] SadiJr commented on a change in pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
SadiJr commented on a change in pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#discussion_r670468794



##########
File path: ui/src/views/AutogenView.vue
##########
@@ -834,6 +834,10 @@ export default {
         params.isofilter = 'executable'
       } else if (possibleApi === 'listHosts') {
         params.type = 'routing'
+      } else if (possibleApi === 'listNetworkOfferings') {
+        if (this.resource && this.resource.type) {

Review comment:
       Wouldn't it be better to add this if to the else statement?
   Like
   ```
   } else if (possibleApi === 'listNetworkOfferings' && (this.resource && this.resource.type)) {
      params.guestiptype = this.resource.type
   }
   ```
   
   Or
   ```
   } else if (possibleApi === 'listNetworkOfferings' && this.resource && this.resource.type) {
      params.guestiptype = this.resource.type
   }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893826935


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-888155274


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 667


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#discussion_r678110579



##########
File path: ui/src/views/AutogenView.vue
##########
@@ -834,6 +834,10 @@ export default {
         params.isofilter = 'executable'
       } else if (possibleApi === 'listHosts') {
         params.type = 'routing'
+      } else if (possibleApi === 'listNetworkOfferings') {
+        if (this.resource && this.resource.type) {

Review comment:
       @SadiJr done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921636317


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893783910


   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-915764211


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921579518


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921625837


   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 1296


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-891827179


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 737


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-920553554


   @shwstppr @NuxRo please advise when the PR is ready for review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-892268245


   <b>Trillian test result (tid-1462)</b>
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38431 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5181-t1462-vmware-65u2.zip
   Smoke tests completed. 89 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-891846250


   @blueorangutan test centos7 vmware-65u2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921616644


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-922186734


   @blueorangutan test centos7 vmware-65u2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893277637


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-894577413


   <b>Trillian test result (tid-1504)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 65804 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5181-t1504-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_network.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 84 look OK, 5 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 256.78 | test_internal_lb.py
   test_01_vpc_privategw_acl | `Error` | 70.78 | test_privategw_acl.py
   test_02_vpc_privategw_static_routes | `Error` | 607.60 | test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 165.02 | test_privategw_acl.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 534.57 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 657.39 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 640.50 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 569.05 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 569.07 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 1529.55 | test_host_maintenance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893361582


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-915763137


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893397087






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-894012267


   @shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921616910


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-914994400


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-888963865


   @shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-888963565


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893447755


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 764


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-888157552


   @shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893834995


   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian. SL-JID 770


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893996718


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 774


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-892570995


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921579315


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921731458


   @shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-922124306


   <b>Trillian test result (tid-2113)</b>
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38482 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5181-t2113-vmware-65u2.zip
   Smoke tests completed. 85 look OK, 4 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_DeployVmAntiAffinityGroup_in_project | `Error` | 119.64 | test_affinity_groups_projects.py
   test_DeployVmAntiAffinityGroup | `Error` | 47.65 | test_affinity_groups.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 32.97 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 54.81 | test_snapshots.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-892570753


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893790449


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-894012205


   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893859681


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921686500


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-922666074


   this work is split into PRs mentioning this above (#5470 and #5471) as the bits of work are divisable and might not both go in.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921728947


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921729463


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-922332546


   <b>Trillian test result (tid-2118)</b>
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 36792 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5181-t2118-vmware-65u2.zip
   Smoke tests completed. 89 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921653925


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1299


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921579518


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#discussion_r704222279



##########
File path: server/src/main/java/com/cloud/hypervisor/HypervisorGuruBase.java
##########
@@ -97,6 +98,24 @@
     public static ConfigKey<Boolean> VmMinCpuSpeedEqualsCpuSpeedDividedByCpuOverprovisioningFactor = new ConfigKey<Boolean>("Advanced", Boolean.class, "vm.min.cpu.speed.equals.cpu.speed.divided.by.cpu.overprovisioning.factor", "true",
             "If we set this to 'true', a minimum CPU speed (cpu speed/ cpu.overprovisioning.factor) will be set on the VM, independent of using a scalable service offering or not.", true, ConfigKey.Scope.Cluster);
 
+    private Map<NetworkOffering.Detail, String> getNicDetails(Network network) {
+        Map<NetworkOffering.Detail, String> details = null;
+        if (network != null) {

Review comment:
       @GutoVeronezi done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-914933534


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-914934352


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#discussion_r709967287



##########
File path: server/src/main/java/com/cloud/hypervisor/HypervisorGuruBase.java
##########
@@ -97,6 +98,25 @@
     public static ConfigKey<Boolean> VmMinCpuSpeedEqualsCpuSpeedDividedByCpuOverprovisioningFactor = new ConfigKey<Boolean>("Advanced", Boolean.class, "vm.min.cpu.speed.equals.cpu.speed.divided.by.cpu.overprovisioning.factor", "true",
             "If we set this to 'true', a minimum CPU speed (cpu speed/ cpu.overprovisioning.factor) will be set on the VM, independent of using a scalable service offering or not.", true, ConfigKey.Scope.Cluster);
 
+    private Map<NetworkOffering.Detail, String> getNicDetails(Network network) {
+        if (network == null) {
+            s_logger.debug("Unable to get NIC details as the network is null");
+            return null;
+        }
+        Map<NetworkOffering.Detail, String> details = networkOfferingDetailsDao.getNtwkOffDetails(network.getNetworkOfferingId());
+        if (details != null) {
+            details.putIfAbsent(NetworkOffering.Detail.PromiscuousMode, NetworkOrchestrationService.PromiscuousMode.value().toString());
+            details.putIfAbsent(NetworkOffering.Detail.MacAddressChanges, NetworkOrchestrationService.MacAddressChanges.value().toString());
+            details.putIfAbsent(NetworkOffering.Detail.ForgedTransmits, NetworkOrchestrationService.ForgedTransmits.value().toString());
+            details.putIfAbsent(NetworkOffering.Detail.MacLearning, NetworkOrchestrationService.MacLearning.value().toString());

Review comment:
       @sureshanaparti No, I think they are set for all NICs as it was done before. See ln 220 in the old code of the diff




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] NuxRo commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
NuxRo commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-918002699


   LGTM, did a few tests and the features seem to work well. :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-896694139


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] SadiJr commented on a change in pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
SadiJr commented on a change in pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#discussion_r670468794



##########
File path: ui/src/views/AutogenView.vue
##########
@@ -834,6 +834,10 @@ export default {
         params.isofilter = 'executable'
       } else if (possibleApi === 'listHosts') {
         params.type = 'routing'
+      } else if (possibleApi === 'listNetworkOfferings') {
+        if (this.resource && this.resource.type) {

Review comment:
       Wouldn't it be better to add this if to the else statement?
   Like
   ```
   } else if (possibleApi === 'listNetworkOfferings' && (this.resource && this.resource.type)) {
      params.guestiptype = this.resource.type
   }
   ```
   
   Or
   ```
   } else if (possibleApi === 'listNetworkOfferings' && this.resource && this.resource.type) {
      params.guestiptype = this.resource.type
   }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-914933534


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-922186796


   @shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893827371


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893783910


   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893210235


   Test failures seem unrelated. Not seen in manual run
   [manualtest.txt](https://github.com/apache/cloudstack/files/6936531/manualtest.txt)
   Will re-run thru BO


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-894584214


   <b>Trillian test result (tid-1511)</b>
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 60883 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5181-t1511-vmware-65u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_network.py
   Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 85 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_primary_storage_disabled_host | `Error` | 0.57 | test_primary_storage.py
   test_01_primary_storage_nfs | `Error` | 0.10 | test_primary_storage.py
   ContextSuite context=TestStorageTags>:setup | `Error` | 0.19 | test_primary_storage.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 1.17 | test_snapshots.py
   test_03_ssvm_internals | `Failure` | 127.72 | test_ssvm.py
   test_08_migrate_vm | `Error` | 53.98 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-888157552


   @shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893068472


   <b>Trillian test result (tid-1468)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 61924 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5181-t1468-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 86 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_06_stop_cpvm | `Failure` | 970.97 | test_ssvm.py
   test_08_reboot_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_10_reboot_cpvm_forced | `Failure` | 0.03 | test_ssvm.py
   test_12_destroy_cpvm | `Error` | 2286.40 | test_ssvm.py
   test_04_extract_template | `Failure` | 128.33 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921686989


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#discussion_r710827232



##########
File path: server/src/main/java/com/cloud/hypervisor/HypervisorGuruBase.java
##########
@@ -97,6 +98,25 @@
     public static ConfigKey<Boolean> VmMinCpuSpeedEqualsCpuSpeedDividedByCpuOverprovisioningFactor = new ConfigKey<Boolean>("Advanced", Boolean.class, "vm.min.cpu.speed.equals.cpu.speed.divided.by.cpu.overprovisioning.factor", "true",
             "If we set this to 'true', a minimum CPU speed (cpu speed/ cpu.overprovisioning.factor) will be set on the VM, independent of using a scalable service offering or not.", true, ConfigKey.Scope.Cluster);
 
+    private Map<NetworkOffering.Detail, String> getNicDetails(Network network) {
+        if (network == null) {
+            s_logger.debug("Unable to get NIC details as the network is null");
+            return null;
+        }
+        Map<NetworkOffering.Detail, String> details = networkOfferingDetailsDao.getNtwkOffDetails(network.getNetworkOfferingId());
+        if (details != null) {
+            details.putIfAbsent(NetworkOffering.Detail.PromiscuousMode, NetworkOrchestrationService.PromiscuousMode.value().toString());
+            details.putIfAbsent(NetworkOffering.Detail.MacAddressChanges, NetworkOrchestrationService.MacAddressChanges.value().toString());
+            details.putIfAbsent(NetworkOffering.Detail.ForgedTransmits, NetworkOrchestrationService.ForgedTransmits.value().toString());
+            details.putIfAbsent(NetworkOffering.Detail.MacLearning, NetworkOrchestrationService.MacLearning.value().toString());

Review comment:
       @sureshanaparti yeah, maybe for the next milestone we can have PR that refactors this and use details only for the required hypervisor type




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr closed pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921711834


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-892583859






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-892570753






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-892570995






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-896710942


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 841


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893790771


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#discussion_r710779829



##########
File path: server/src/main/java/com/cloud/hypervisor/HypervisorGuruBase.java
##########
@@ -97,6 +98,25 @@
     public static ConfigKey<Boolean> VmMinCpuSpeedEqualsCpuSpeedDividedByCpuOverprovisioningFactor = new ConfigKey<Boolean>("Advanced", Boolean.class, "vm.min.cpu.speed.equals.cpu.speed.divided.by.cpu.overprovisioning.factor", "true",
             "If we set this to 'true', a minimum CPU speed (cpu speed/ cpu.overprovisioning.factor) will be set on the VM, independent of using a scalable service offering or not.", true, ConfigKey.Scope.Cluster);
 
+    private Map<NetworkOffering.Detail, String> getNicDetails(Network network) {
+        if (network == null) {
+            s_logger.debug("Unable to get NIC details as the network is null");
+            return null;
+        }
+        Map<NetworkOffering.Detail, String> details = networkOfferingDetailsDao.getNtwkOffDetails(network.getNetworkOfferingId());
+        if (details != null) {
+            details.putIfAbsent(NetworkOffering.Detail.PromiscuousMode, NetworkOrchestrationService.PromiscuousMode.value().toString());
+            details.putIfAbsent(NetworkOffering.Detail.MacAddressChanges, NetworkOrchestrationService.MacAddressChanges.value().toString());
+            details.putIfAbsent(NetworkOffering.Detail.ForgedTransmits, NetworkOrchestrationService.ForgedTransmits.value().toString());
+            details.putIfAbsent(NetworkOffering.Detail.MacLearning, NetworkOrchestrationService.MacLearning.value().toString());

Review comment:
       OK @shwstppr If there are set for hypervisors other than VMware, and not necessary. We can fix that in a new PR. What do you say?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921637021


   @sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on a change in pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#discussion_r683465834



##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
##########
@@ -956,6 +952,11 @@ public static boolean isSpecMatch(DVPortgroupConfigInfo currentDvPortgroupInfo,
                 specMatches = false;
             }
         }
+        if (currentPortSetting.getMacManagementPolicy() != null && newPortSetting.getMacManagementPolicy() != null &&
+                currentPortSetting.getMacManagementPolicy().getMacLearningPolicy() != null && newPortSetting.getMacManagementPolicy().getMacLearningPolicy() != null &&
+                currentPortSetting.getMacManagementPolicy().getMacLearningPolicy().isEnabled() != newPortSetting.getMacManagementPolicy().getMacLearningPolicy().isEnabled()) {

Review comment:
       Can you extract this big `if` clause into a method to improve readability? Then this could be like:
   ````
   if (hasMacLearningPolicyChanged(currentPortSetting, newPortSetting) {
      specMatches = false;
   }
   ```` 

##########
File path: server/src/main/java/com/cloud/network/NetworkServiceImpl.java
##########
@@ -2144,6 +2152,38 @@ private boolean checkForNonStoppedVmInNetwork(long networkId) {
         return vms.isEmpty();
     }
 
+    private void replugNicsForUpdatedNetwork(NetworkVO network) throws ResourceUnavailableException, InsufficientCapacityException {
+        List<NicVO> nics = _nicDao.listByNetworkId(network.getId());
+        Network updatedNetwork = getNetwork(network.getId());
+        for (NicVO nic : nics) {
+            long vmId = nic.getInstanceId();
+            VMInstanceVO vm = _vmDao.findById(vmId);
+            if (vm == null) {
+                s_logger.error("VM for nic " + nic.getId() + " not found with Vm Id:" + vmId);
+                continue;
+            }
+            if (!Hypervisor.HypervisorType.VMware.equals(vm.getHypervisorType())) {
+                s_logger.debug("VM is not on VMware");

Review comment:
       Maybe add more information to the following log lines? Something like: `Cannot replug nic <ID> as: VM ...`

##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
##########
@@ -1215,6 +1218,35 @@ public static DVSSecurityPolicy createDVSSecurityPolicy(Map<NetworkOffering.Deta
         return secPolicy;
     }
 
+    public static DVSMacManagementPolicy createDVSMacManagementPolicy(Map<NetworkOffering.Detail, String> nicDetails) {
+        DVSMacManagementPolicy macManagementPolicy = new DVSMacManagementPolicy();
+        macManagementPolicy.setAllowPromiscuous(false);

Review comment:
       Minor improvement to reduce lines of code:
   ````
   macManagementPolicy.setAllowPromiscuous(
      nicDetails.containsKey(NetworkOffering.Detail.PromiscuousMode) ? 
      Boolean.valueOf(nicDetails.get(NetworkOffering.Detail.PromiscuousMode)) : false);
   ````
   Same for the other properties. Then you won't need the if blocks below.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893381203


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893868317


   Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian. SL-JID 771


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-892398463


   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893062866


   <b>Trillian test result (tid-1467)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 61451 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5181-t1467-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_network.py
   Intermittent failure detected: /marvin/tests/smoke/test_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_deployment_planner.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 82 look OK, 7 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_primary_storage_disabled_host | `Error` | 17.48 | test_primary_storage.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 225.33 | test_internal_lb.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 3673.43 | test_kubernetes_clusters.py
   test_02_vpc_privategw_static_routes | `Failure` | 1233.47 | test_privategw_acl.py
   test_03_RVR_Network_check_router_state | `Error` | 39.34 | test_routers_network_ops.py
   test_01_deploy_vm_on_specific_host | `Error` | 1.47 | test_vm_deployment_planner.py
   test_02_deploy_vm_on_specific_cluster | `Error` | 88.98 | test_vm_deployment_planner.py
   test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 1.15 | test_vm_deployment_planner.py
   test_08_migrate_vm | `Error` | 0.04 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-892398584


   @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-916347189


   @shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-891844829


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921580413


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893381203


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893790449


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921731311


   @blueorangutan test centos7 vmware-65u2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893429171


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921712069


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893784169


   @shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921614922


   @blueorangutan packjage


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921580698


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893834995






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-891811239


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893277978






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-888156845


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893826935


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-896694702


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893784169


   @shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-915763470


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-915777070


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1191


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-916346511


   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-894039039


   <b>Trillian Build Failed (tid-1506)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-893277637


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-892583859






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-921614922


   @blueorangutan packjage


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5181: vmware, ui: update portgroup on network offering change

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#issuecomment-914992625


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1169


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org