[GitHub] [iotdb] SilverNarcissus commented on a change in pull request #2405: [IOTDB-1079] Virtual storage group first mile stone

[GitBox <gi...@apache.org>]

SilverNarcissus commented on a change in pull request #2405:
URL: https://github.com/apache/iotdb/pull/2405#discussion_r557151865



##########
File path: server/src/assembly/resources/conf/iotdb-engine.properties
##########
@@ -231,6 +231,11 @@ mtree_snapshot_interval=100000
 # Only take effect when enable_mtree_snapshot=true.
 mtree_snapshot_threshold_time=3600
 
+# number of virtual storage group
+# virtual storage group is the unit of concurrency in memory
+# recommend value is [storage group number] * [virtual storage group number] = virtual cpu core number

Review comment:
       fixed~

##########
File path: server/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java
##########
@@ -845,6 +845,11 @@
    */
   private boolean debugState = false;
 
+  /**
+   * the number of virtual storage group
+   */
+  private int virtualStorageGroupNum = 8;

Review comment:
       fixed~




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org