You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Xudong Ni via Review Board <no...@reviews.apache.org> on 2018/08/23 02:56:25 UTC
Re: Review Request 68366: Added a custom port range option to the
`network/ports` isolator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68366/
-----------------------------------------------------------
(Updated Aug. 23, 2018, 2:56 a.m.)
Review request for mesos and James Peach.
Summary (updated)
-----------------
Added a custom port range option to the `network/ports` isolator.
Bugs: MESOS-9133
https://issues.apache.org/jira/browse/MESOS-9133
Repository: mesos
Description (updated)
-------
Added the `--container_ports_isolated_range` flag to the
`network/ports` isolator. This allows the operator to specify a custom
port range to be protected by the isolator. If a task listens on a port
that it isn't holding resources for, the isolator will not raise a
limitation unless the port is within this range. We can represent the
`--check_agent_port_range_only` as a special case of a protected range.
Diffs (updated)
-----
docs/configuration/agent.md e98a9786aa2d1f5c87aec4db8b65457c3293156e
docs/isolators/network-ports.md 5d14fc2985e099783b09e2a19f99641b4ddbd768
src/slave/containerizer/mesos/isolators/network/ports.hpp 6944d01e0f8a11eda381ef1754f19ee0cf9359c8
src/slave/containerizer/mesos/isolators/network/ports.cpp 2a7ff2530f898cf892739c715b07b3387b423ed9
src/slave/flags.hpp bff194fef98f38a8b91d86ef4ec99889d0cfe31f
src/slave/flags.cpp e017f3921a0bccc03f6ef639a04163bf7fc4e79b
src/tests/containerizer/ports_isolator_tests.cpp db080c4e9c8b0c036294a8f7a42617ca1231f884
Diff: https://reviews.apache.org/r/68366/diff/7/
Changes: https://reviews.apache.org/r/68366/diff/6-7/
Testing (updated)
-------
New test added to test feature:
[ OK ] NetworkPortsIsolatorTest.ROOT_NC_PortEnforcementIsolatedPort (1678 ms)
[----------] 1 test from NetworkPortsIsolatorTest (1679 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1691 ms total)
[ PASSED ] 1 test.
Existing test updated to test the negative cases:
[ OK ] NetworkPortsIsolatorTest.ROOT_IsolatorFlags (73 ms)
[----------] 1 test from NetworkPortsIsolatorTest (73 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (85 ms total)
[ PASSED ] 1 test.
Existing test for isolator feature:
[ OK ] NetworkPortsIsolatorTest.ROOT_NC_NoPortEnforcement (1789 ms)
[----------] 1 test from NetworkPortsIsolatorTest (1790 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1801 ms total)
[ PASSED ] 1 test.
[ OK ] NetworkPortsIsolatorTest.ROOT_NC_NoPortsResource (1795 ms)
[----------] 1 test from NetworkPortsIsolatorTest (1795 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1806 ms total)
[ PASSED ] 1 test.
[ OK ] NetworkPortsIsolatorTest.ROOT_NC_AllocatedPorts (1782 ms)
[----------] 1 test from NetworkPortsIsolatorTest (1783 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1794 ms total)
[ PASSED ] 1 test.
Thanks,
Xudong Ni
Re: Review Request 68366: Added a custom port range option to the
`network/ports` isolator.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68366/#review207796
-----------------------------------------------------------
PASS: Mesos patch 68366 was successfully built and tested.
Reviews applied: `['68366']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2223/mesos-review-68366
- Mesos Reviewbot Windows
On Aug. 23, 2018, 2:56 a.m., Xudong Ni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68366/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 2:56 a.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-9133
> https://issues.apache.org/jira/browse/MESOS-9133
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the `--container_ports_isolated_range` flag to the
> `network/ports` isolator. This allows the operator to specify a custom
> port range to be protected by the isolator. If a task listens on a port
> that it isn't holding resources for, the isolator will not raise a
> limitation unless the port is within this range. We can represent the
> `--check_agent_port_range_only` as a special case of a protected range.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md e98a9786aa2d1f5c87aec4db8b65457c3293156e
> docs/isolators/network-ports.md 5d14fc2985e099783b09e2a19f99641b4ddbd768
> src/slave/containerizer/mesos/isolators/network/ports.hpp 6944d01e0f8a11eda381ef1754f19ee0cf9359c8
> src/slave/containerizer/mesos/isolators/network/ports.cpp 2a7ff2530f898cf892739c715b07b3387b423ed9
> src/slave/flags.hpp bff194fef98f38a8b91d86ef4ec99889d0cfe31f
> src/slave/flags.cpp e017f3921a0bccc03f6ef639a04163bf7fc4e79b
> src/tests/containerizer/ports_isolator_tests.cpp db080c4e9c8b0c036294a8f7a42617ca1231f884
>
>
> Diff: https://reviews.apache.org/r/68366/diff/7/
>
>
> Testing
> -------
>
> New test added to test feature:
>
> [ OK ] NetworkPortsIsolatorTest.ROOT_NC_PortEnforcementIsolatedPort (1678 ms)
> [----------] 1 test from NetworkPortsIsolatorTest (1679 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1691 ms total)
> [ PASSED ] 1 test.
>
> Existing test updated to test the negative cases:
>
> [ OK ] NetworkPortsIsolatorTest.ROOT_IsolatorFlags (73 ms)
> [----------] 1 test from NetworkPortsIsolatorTest (73 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (85 ms total)
> [ PASSED ] 1 test.
>
> Existing test for isolator feature:
>
> [ OK ] NetworkPortsIsolatorTest.ROOT_NC_NoPortEnforcement (1789 ms)
> [----------] 1 test from NetworkPortsIsolatorTest (1790 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1801 ms total)
> [ PASSED ] 1 test.
>
> [ OK ] NetworkPortsIsolatorTest.ROOT_NC_NoPortsResource (1795 ms)
> [----------] 1 test from NetworkPortsIsolatorTest (1795 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1806 ms total)
> [ PASSED ] 1 test.
>
> [ OK ] NetworkPortsIsolatorTest.ROOT_NC_AllocatedPorts (1782 ms)
> [----------] 1 test from NetworkPortsIsolatorTest (1783 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1794 ms total)
> [ PASSED ] 1 test.
>
>
> Thanks,
>
> Xudong Ni
>
>
Re: Review Request 68366: Added a custom port range option to the
`network/ports` isolator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68366/#review207797
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68366]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 23, 2018, 2:56 a.m., Xudong Ni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68366/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 2:56 a.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-9133
> https://issues.apache.org/jira/browse/MESOS-9133
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the `--container_ports_isolated_range` flag to the
> `network/ports` isolator. This allows the operator to specify a custom
> port range to be protected by the isolator. If a task listens on a port
> that it isn't holding resources for, the isolator will not raise a
> limitation unless the port is within this range. We can represent the
> `--check_agent_port_range_only` as a special case of a protected range.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md e98a9786aa2d1f5c87aec4db8b65457c3293156e
> docs/isolators/network-ports.md 5d14fc2985e099783b09e2a19f99641b4ddbd768
> src/slave/containerizer/mesos/isolators/network/ports.hpp 6944d01e0f8a11eda381ef1754f19ee0cf9359c8
> src/slave/containerizer/mesos/isolators/network/ports.cpp 2a7ff2530f898cf892739c715b07b3387b423ed9
> src/slave/flags.hpp bff194fef98f38a8b91d86ef4ec99889d0cfe31f
> src/slave/flags.cpp e017f3921a0bccc03f6ef639a04163bf7fc4e79b
> src/tests/containerizer/ports_isolator_tests.cpp db080c4e9c8b0c036294a8f7a42617ca1231f884
>
>
> Diff: https://reviews.apache.org/r/68366/diff/7/
>
>
> Testing
> -------
>
> New test added to test feature:
>
> [ OK ] NetworkPortsIsolatorTest.ROOT_NC_PortEnforcementIsolatedPort (1678 ms)
> [----------] 1 test from NetworkPortsIsolatorTest (1679 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1691 ms total)
> [ PASSED ] 1 test.
>
> Existing test updated to test the negative cases:
>
> [ OK ] NetworkPortsIsolatorTest.ROOT_IsolatorFlags (73 ms)
> [----------] 1 test from NetworkPortsIsolatorTest (73 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (85 ms total)
> [ PASSED ] 1 test.
>
> Existing test for isolator feature:
>
> [ OK ] NetworkPortsIsolatorTest.ROOT_NC_NoPortEnforcement (1789 ms)
> [----------] 1 test from NetworkPortsIsolatorTest (1790 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1801 ms total)
> [ PASSED ] 1 test.
>
> [ OK ] NetworkPortsIsolatorTest.ROOT_NC_NoPortsResource (1795 ms)
> [----------] 1 test from NetworkPortsIsolatorTest (1795 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1806 ms total)
> [ PASSED ] 1 test.
>
> [ OK ] NetworkPortsIsolatorTest.ROOT_NC_AllocatedPorts (1782 ms)
> [----------] 1 test from NetworkPortsIsolatorTest (1783 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1794 ms total)
> [ PASSED ] 1 test.
>
>
> Thanks,
>
> Xudong Ni
>
>
Re: Review Request 68366: Added a custom port range option to the
`network/ports` isolator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68366/#review207845
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68366]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 23, 2018, 10:16 p.m., Xudong Ni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68366/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 10:16 p.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-9133
> https://issues.apache.org/jira/browse/MESOS-9133
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the `--container_ports_isolated_range` flag to the
> `network/ports` isolator. This allows the operator to specify a custom
> port range to be protected by the isolator. If a task listens on a port
> that it isn't holding resources for, the isolator will not raise a
> limitation unless the port is within this range. We can represent the
> `--check_agent_port_range_only` as a special case of a protected range.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md e98a9786aa2d1f5c87aec4db8b65457c3293156e
> docs/isolators/network-ports.md 5d14fc2985e099783b09e2a19f99641b4ddbd768
> src/slave/containerizer/mesos/isolators/network/ports.hpp 6944d01e0f8a11eda381ef1754f19ee0cf9359c8
> src/slave/containerizer/mesos/isolators/network/ports.cpp 2a7ff2530f898cf892739c715b07b3387b423ed9
> src/slave/flags.hpp bff194fef98f38a8b91d86ef4ec99889d0cfe31f
> src/slave/flags.cpp e017f3921a0bccc03f6ef639a04163bf7fc4e79b
> src/tests/containerizer/ports_isolator_tests.cpp db080c4e9c8b0c036294a8f7a42617ca1231f884
>
>
> Diff: https://reviews.apache.org/r/68366/diff/8/
>
>
> Testing
> -------
>
> New test added to test feature:
>
> [ OK ] NetworkPortsIsolatorTest.ROOT_NC_PortEnforcementIsolatedPort (1794 ms)
> [----------] 1 test from NetworkPortsIsolatorTest (1794 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1806 ms total)
> [ PASSED ] 1 test.
>
> Existing test updated to test the negative cases:
>
> [ OK ] NetworkPortsIsolatorTest.ROOT_IsolatorFlags (78 ms)
> [----------] 1 test from NetworkPortsIsolatorTest (78 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (91 ms total)
> [ PASSED ] 1 test
>
> Existing test for isolator feature:
>
> [ OK ] NetworkPortsIsolatorTest.ROOT_NC_NoPortEnforcement (1798 ms)
> [----------] 1 test from NetworkPortsIsolatorTest (1798 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1810 ms total)
> [ PASSED ] 1 test.
>
> [ OK ] NetworkPortsIsolatorTest.ROOT_NC_NoPortsResource (1772 ms)
> [----------] 1 test from NetworkPortsIsolatorTest (1773 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1784 ms total)
> [ PASSED ] 1 test.
>
> [ OK ] NetworkPortsIsolatorTest.ROOT_NC_AllocatedPorts (1827 ms)
> [----------] 1 test from NetworkPortsIsolatorTest (1828 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1841 ms total)
> [ PASSED ] 1 test.
>
>
> Thanks,
>
> Xudong Ni
>
>
Re: Review Request 68366: Added a custom port range option to the
`network/ports` isolator.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68366/#review207843
-----------------------------------------------------------
PASS: Mesos patch 68366 was successfully built and tested.
Reviews applied: `['68366']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2227/mesos-review-68366
- Mesos Reviewbot Windows
On Aug. 23, 2018, 10:16 p.m., Xudong Ni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68366/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 10:16 p.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-9133
> https://issues.apache.org/jira/browse/MESOS-9133
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the `--container_ports_isolated_range` flag to the
> `network/ports` isolator. This allows the operator to specify a custom
> port range to be protected by the isolator. If a task listens on a port
> that it isn't holding resources for, the isolator will not raise a
> limitation unless the port is within this range. We can represent the
> `--check_agent_port_range_only` as a special case of a protected range.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md e98a9786aa2d1f5c87aec4db8b65457c3293156e
> docs/isolators/network-ports.md 5d14fc2985e099783b09e2a19f99641b4ddbd768
> src/slave/containerizer/mesos/isolators/network/ports.hpp 6944d01e0f8a11eda381ef1754f19ee0cf9359c8
> src/slave/containerizer/mesos/isolators/network/ports.cpp 2a7ff2530f898cf892739c715b07b3387b423ed9
> src/slave/flags.hpp bff194fef98f38a8b91d86ef4ec99889d0cfe31f
> src/slave/flags.cpp e017f3921a0bccc03f6ef639a04163bf7fc4e79b
> src/tests/containerizer/ports_isolator_tests.cpp db080c4e9c8b0c036294a8f7a42617ca1231f884
>
>
> Diff: https://reviews.apache.org/r/68366/diff/8/
>
>
> Testing
> -------
>
> New test added to test feature:
>
> [ OK ] NetworkPortsIsolatorTest.ROOT_NC_PortEnforcementIsolatedPort (1794 ms)
> [----------] 1 test from NetworkPortsIsolatorTest (1794 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1806 ms total)
> [ PASSED ] 1 test.
>
> Existing test updated to test the negative cases:
>
> [ OK ] NetworkPortsIsolatorTest.ROOT_IsolatorFlags (78 ms)
> [----------] 1 test from NetworkPortsIsolatorTest (78 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (91 ms total)
> [ PASSED ] 1 test
>
> Existing test for isolator feature:
>
> [ OK ] NetworkPortsIsolatorTest.ROOT_NC_NoPortEnforcement (1798 ms)
> [----------] 1 test from NetworkPortsIsolatorTest (1798 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1810 ms total)
> [ PASSED ] 1 test.
>
> [ OK ] NetworkPortsIsolatorTest.ROOT_NC_NoPortsResource (1772 ms)
> [----------] 1 test from NetworkPortsIsolatorTest (1773 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1784 ms total)
> [ PASSED ] 1 test.
>
> [ OK ] NetworkPortsIsolatorTest.ROOT_NC_AllocatedPorts (1827 ms)
> [----------] 1 test from NetworkPortsIsolatorTest (1828 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1841 ms total)
> [ PASSED ] 1 test.
>
>
> Thanks,
>
> Xudong Ni
>
>
Re: Review Request 68366: Added a custom port range option to the
`network/ports` isolator.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68366/#review207926
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On Aug. 24, 2018, 10:54 p.m., Xudong Ni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68366/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 10:54 p.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-9133
> https://issues.apache.org/jira/browse/MESOS-9133
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the `--container_ports_isolated_range` flag to the
> `network/ports` isolator. This allows the operator to specify a custom
> port range to be protected by the isolator. If a task listens on a port
> that it isn't holding resources for, the isolator will not raise a
> limitation unless the port is within this range. We can represent the
> `--check_agent_port_range_only` as a special case of a protected range.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md e98a9786aa2d1f5c87aec4db8b65457c3293156e
> docs/isolators/network-ports.md 5d14fc2985e099783b09e2a19f99641b4ddbd768
> src/slave/containerizer/mesos/isolators/network/ports.hpp 6944d01e0f8a11eda381ef1754f19ee0cf9359c8
> src/slave/containerizer/mesos/isolators/network/ports.cpp 2a7ff2530f898cf892739c715b07b3387b423ed9
> src/slave/flags.hpp bff194fef98f38a8b91d86ef4ec99889d0cfe31f
> src/slave/flags.cpp e017f3921a0bccc03f6ef639a04163bf7fc4e79b
> src/tests/containerizer/ports_isolator_tests.cpp db080c4e9c8b0c036294a8f7a42617ca1231f884
>
>
> Diff: https://reviews.apache.org/r/68366/diff/9/
>
>
> Testing
> -------
>
> sudo GLOG_v=1 ./bin/mesos-tests.sh --verbose --gtest_filter="NetworkPortsIsolatorTest.*"
>
> [----------] 13 tests from NetworkPortsIsolatorTest (26387 ms total)
>
> [----------] Global test environment tear-down
> [==========] 13 tests from 1 test case ran. (26399 ms total)
> [ PASSED ] 13 tests.
>
>
> Thanks,
>
> Xudong Ni
>
>
Re: Review Request 68366: Added a custom port range option to the
`network/ports` isolator.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68366/#review207931
-----------------------------------------------------------
PASS: Mesos patch 68366 was successfully built and tested.
Reviews applied: `['68366']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2237/mesos-review-68366
- Mesos Reviewbot Windows
On Aug. 24, 2018, 10:54 p.m., Xudong Ni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68366/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 10:54 p.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-9133
> https://issues.apache.org/jira/browse/MESOS-9133
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the `--container_ports_isolated_range` flag to the
> `network/ports` isolator. This allows the operator to specify a custom
> port range to be protected by the isolator. If a task listens on a port
> that it isn't holding resources for, the isolator will not raise a
> limitation unless the port is within this range. We can represent the
> `--check_agent_port_range_only` as a special case of a protected range.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md e98a9786aa2d1f5c87aec4db8b65457c3293156e
> docs/isolators/network-ports.md 5d14fc2985e099783b09e2a19f99641b4ddbd768
> src/slave/containerizer/mesos/isolators/network/ports.hpp 6944d01e0f8a11eda381ef1754f19ee0cf9359c8
> src/slave/containerizer/mesos/isolators/network/ports.cpp 2a7ff2530f898cf892739c715b07b3387b423ed9
> src/slave/flags.hpp bff194fef98f38a8b91d86ef4ec99889d0cfe31f
> src/slave/flags.cpp e017f3921a0bccc03f6ef639a04163bf7fc4e79b
> src/tests/containerizer/ports_isolator_tests.cpp db080c4e9c8b0c036294a8f7a42617ca1231f884
>
>
> Diff: https://reviews.apache.org/r/68366/diff/9/
>
>
> Testing
> -------
>
> sudo GLOG_v=1 ./bin/mesos-tests.sh --verbose --gtest_filter="NetworkPortsIsolatorTest.*"
>
> [----------] 13 tests from NetworkPortsIsolatorTest (26387 ms total)
>
> [----------] Global test environment tear-down
> [==========] 13 tests from 1 test case ran. (26399 ms total)
> [ PASSED ] 13 tests.
>
>
> Thanks,
>
> Xudong Ni
>
>
Re: Review Request 68366: Added a custom port range option to the
`network/ports` isolator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68366/#review207932
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68366]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 24, 2018, 10:54 p.m., Xudong Ni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68366/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 10:54 p.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-9133
> https://issues.apache.org/jira/browse/MESOS-9133
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the `--container_ports_isolated_range` flag to the
> `network/ports` isolator. This allows the operator to specify a custom
> port range to be protected by the isolator. If a task listens on a port
> that it isn't holding resources for, the isolator will not raise a
> limitation unless the port is within this range. We can represent the
> `--check_agent_port_range_only` as a special case of a protected range.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md e98a9786aa2d1f5c87aec4db8b65457c3293156e
> docs/isolators/network-ports.md 5d14fc2985e099783b09e2a19f99641b4ddbd768
> src/slave/containerizer/mesos/isolators/network/ports.hpp 6944d01e0f8a11eda381ef1754f19ee0cf9359c8
> src/slave/containerizer/mesos/isolators/network/ports.cpp 2a7ff2530f898cf892739c715b07b3387b423ed9
> src/slave/flags.hpp bff194fef98f38a8b91d86ef4ec99889d0cfe31f
> src/slave/flags.cpp e017f3921a0bccc03f6ef639a04163bf7fc4e79b
> src/tests/containerizer/ports_isolator_tests.cpp db080c4e9c8b0c036294a8f7a42617ca1231f884
>
>
> Diff: https://reviews.apache.org/r/68366/diff/9/
>
>
> Testing
> -------
>
> sudo GLOG_v=1 ./bin/mesos-tests.sh --verbose --gtest_filter="NetworkPortsIsolatorTest.*"
>
> [----------] 13 tests from NetworkPortsIsolatorTest (26387 ms total)
>
> [----------] Global test environment tear-down
> [==========] 13 tests from 1 test case ran. (26399 ms total)
> [ PASSED ] 13 tests.
>
>
> Thanks,
>
> Xudong Ni
>
>
Re: Review Request 68366: Added a custom port range option to the
`network/ports` isolator.
Posted by Xudong Ni via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68366/
-----------------------------------------------------------
(Updated Aug. 24, 2018, 10:54 p.m.)
Review request for mesos and James Peach.
Bugs: MESOS-9133
https://issues.apache.org/jira/browse/MESOS-9133
Repository: mesos
Description
-------
Added the `--container_ports_isolated_range` flag to the
`network/ports` isolator. This allows the operator to specify a custom
port range to be protected by the isolator. If a task listens on a port
that it isn't holding resources for, the isolator will not raise a
limitation unless the port is within this range. We can represent the
`--check_agent_port_range_only` as a special case of a protected range.
Diffs (updated)
-----
docs/configuration/agent.md e98a9786aa2d1f5c87aec4db8b65457c3293156e
docs/isolators/network-ports.md 5d14fc2985e099783b09e2a19f99641b4ddbd768
src/slave/containerizer/mesos/isolators/network/ports.hpp 6944d01e0f8a11eda381ef1754f19ee0cf9359c8
src/slave/containerizer/mesos/isolators/network/ports.cpp 2a7ff2530f898cf892739c715b07b3387b423ed9
src/slave/flags.hpp bff194fef98f38a8b91d86ef4ec99889d0cfe31f
src/slave/flags.cpp e017f3921a0bccc03f6ef639a04163bf7fc4e79b
src/tests/containerizer/ports_isolator_tests.cpp db080c4e9c8b0c036294a8f7a42617ca1231f884
Diff: https://reviews.apache.org/r/68366/diff/9/
Changes: https://reviews.apache.org/r/68366/diff/8-9/
Testing (updated)
-------
sudo GLOG_v=1 ./bin/mesos-tests.sh --verbose --gtest_filter="NetworkPortsIsolatorTest.*"
[----------] 13 tests from NetworkPortsIsolatorTest (26387 ms total)
[----------] Global test environment tear-down
[==========] 13 tests from 1 test case ran. (26399 ms total)
[ PASSED ] 13 tests.
Thanks,
Xudong Ni
Re: Review Request 68366: Added a custom port range option to the
`network/ports` isolator.
Posted by Xudong Ni via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68366/
-----------------------------------------------------------
(Updated Aug. 23, 2018, 10:16 p.m.)
Review request for mesos and James Peach.
Bugs: MESOS-9133
https://issues.apache.org/jira/browse/MESOS-9133
Repository: mesos
Description
-------
Added the `--container_ports_isolated_range` flag to the
`network/ports` isolator. This allows the operator to specify a custom
port range to be protected by the isolator. If a task listens on a port
that it isn't holding resources for, the isolator will not raise a
limitation unless the port is within this range. We can represent the
`--check_agent_port_range_only` as a special case of a protected range.
Diffs (updated)
-----
docs/configuration/agent.md e98a9786aa2d1f5c87aec4db8b65457c3293156e
docs/isolators/network-ports.md 5d14fc2985e099783b09e2a19f99641b4ddbd768
src/slave/containerizer/mesos/isolators/network/ports.hpp 6944d01e0f8a11eda381ef1754f19ee0cf9359c8
src/slave/containerizer/mesos/isolators/network/ports.cpp 2a7ff2530f898cf892739c715b07b3387b423ed9
src/slave/flags.hpp bff194fef98f38a8b91d86ef4ec99889d0cfe31f
src/slave/flags.cpp e017f3921a0bccc03f6ef639a04163bf7fc4e79b
src/tests/containerizer/ports_isolator_tests.cpp db080c4e9c8b0c036294a8f7a42617ca1231f884
Diff: https://reviews.apache.org/r/68366/diff/8/
Changes: https://reviews.apache.org/r/68366/diff/7-8/
Testing (updated)
-------
New test added to test feature:
[ OK ] NetworkPortsIsolatorTest.ROOT_NC_PortEnforcementIsolatedPort (1794 ms)
[----------] 1 test from NetworkPortsIsolatorTest (1794 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1806 ms total)
[ PASSED ] 1 test.
Existing test updated to test the negative cases:
[ OK ] NetworkPortsIsolatorTest.ROOT_IsolatorFlags (78 ms)
[----------] 1 test from NetworkPortsIsolatorTest (78 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (91 ms total)
[ PASSED ] 1 test
Existing test for isolator feature:
[ OK ] NetworkPortsIsolatorTest.ROOT_NC_NoPortEnforcement (1798 ms)
[----------] 1 test from NetworkPortsIsolatorTest (1798 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1810 ms total)
[ PASSED ] 1 test.
[ OK ] NetworkPortsIsolatorTest.ROOT_NC_NoPortsResource (1772 ms)
[----------] 1 test from NetworkPortsIsolatorTest (1773 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1784 ms total)
[ PASSED ] 1 test.
[ OK ] NetworkPortsIsolatorTest.ROOT_NC_AllocatedPorts (1827 ms)
[----------] 1 test from NetworkPortsIsolatorTest (1828 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1841 ms total)
[ PASSED ] 1 test.
Thanks,
Xudong Ni