You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "fresh-borzoni (via GitHub)" <gi...@apache.org> on 2026/10/12 07:28:23 UTC

[I] [lake] Fail fast when two plugins register the same lake format [fluss]

fresh-borzoni opened a new issue, #4601:
URL: https://github.com/apache/fluss/issues/4601

   ### Search before asking
   
   - [x] I searched in the [issues](https://github.com/apache/fluss/issues) and found nothing similar.
   
   
   ### Description
   
   `LakeStoragePluginSetUp` uses the first lake plugin whose identifier matches the configured format, so if two plugins register the same format (for example the Iceberg 1.10 and 1.12 plugins installed side by side), one is picked silently depending on load order. It should fail with an error naming both, like `ConfigProviders` does for duplicate config providers.
   
   ### Willingness to contribute
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [lake] Fail fast when two plugins register the same lake format [fluss]

Posted by "polyzos (via GitHub)" <gi...@apache.org>.
polyzos commented on issue #4601:
URL: https://github.com/apache/fluss/issues/4601#issuecomment-6139486675

   @Hachiman566 I see it can affect the other tickets, so please go ahead and thank you for your interest 🙌  Assigned to you.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [lake] Fail fast when two plugins register the same lake format [fluss]

Posted by "polyzos (via GitHub)" <gi...@apache.org>.
polyzos closed issue #4601: [lake] Fail fast when two plugins register the same lake format
URL: https://github.com/apache/fluss/issues/4601


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [lake] Fail fast when two plugins register the same lake format [fluss]

Posted by "polyzos (via GitHub)" <gi...@apache.org>.
polyzos commented on issue #4601:
URL: https://github.com/apache/fluss/issues/4601#issuecomment-6444264852

   Hi @Hachiman566, Is there any progress here, because we need to push this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [lake] Fail fast when two plugins register the same lake format [fluss]

Posted by "Hachiman566 (via GitHub)" <gi...@apache.org>.
Hachiman566 commented on issue #4601:
URL: https://github.com/apache/fluss/issues/4601#issuecomment-6445463623

   Hi @polyzos, I’ve opened draft PR #4916 for this issue. The fix and targeted tests are ready. I’ve noted one question about duplicate detection across PluginManager and SPI for review. CI is awaiting maintainer approval.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [lake] Fail fast when two plugins register the same lake format [fluss]

Posted by "Hachiman566 (via GitHub)" <gi...@apache.org>.
Hachiman566 commented on issue #4601:
URL: https://github.com/apache/fluss/issues/4601#issuecomment-6134318868

   I’d like to work on this if it’s still available. I propose detecting a second match for the requested lake format and reporting the format and both implementation classes, following ConfigProviders. I’ll preserve the existing wrapper and no-match behavior, with tests for duplicates within and across PluginManager/SPI.
   
   Should the same implementation discovered through both sources also count as a conflict? I’d avoid deduplicating by class name because separate classloaders may load different versions with the same name.
   
   Does this scope look right? If so, could you assign the issue to me?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org