You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@abdera.apache.org by James M Snell <ja...@gmail.com> on 2006/06/12 23:06:31 UTC

Code status

Both my individual CLA and the code grant have been faxed in.  I'm
currently waiting on confirmation for both.  As soon as I get both, I'll
check in the current source.  In the meantime, later today I will upload
the current snapshot of the source to my personal blog and will post a
link here.

- James

Re: Code status

Posted by James M Snell <ja...@gmail.com>.
Garrett Rooney wrote:
> On 6/12/06, James M Snell <ja...@gmail.com> wrote:
>> New code drop available:
>>
>> http://www.snellspace.com/public/abdera.tar.gz
>>
>> Quite a few changes, not the least of which is a change to the new
>> org.apache.abdera.* package.
> 
> Great!
> 
> One thing I noticed is that the ASF license block doesn't appear in
> all the files (TextFilter.java is the one that I happened to notice it
> missing from).  Also, is there a reason there's a space before
> 'contributor' on the second line of the license blocks?  Looks a bit
> weird.
> 

Copy'n'paste bug.

>> Also included is the beginnings of a project website.  Please take a
>> look and critique.
> 
> The site looks good to me, although your disclaimer about the project
> being under incubation isn't quite the same as the one the incubator
> docs say we should have:
> 
> http://incubator.apache.org/incubation/Incubation_Policy.html#Branding
> 

Fixed!

> You also might want to work the Incubator Logo into the web site, for
> an example of how others have done this see the
> http://incubator.apache.org/harmony/ web site.  Using it in place of
> the ASF logo you've currently got would look reasonably good.
> 

Fixed!

- James

Re: Code status

Posted by James M Snell <ja...@gmail.com>.
Doh! I'm am absolutely terribly proofreader.  Thanks for catching that

Garrett Rooney wrote:
> On 6/12/06, Garrett Rooney <ro...@electricjellyfish.net> wrote:
>> On 6/12/06, Garrett Rooney <ro...@electricjellyfish.net> wrote:
>> > On 6/12/06, James M Snell <ja...@gmail.com> wrote:
>> > > New code drop available:
>> > >
>> > > http://www.snellspace.com/public/abdera.tar.gz
>> > >
>> > > Quite a few changes, not the least of which is a change to the new
>> > > org.apache.abdera.* package.
>> >
>> > Great!
>> >
>> > One thing I noticed is that the ASF license block doesn't appear in
>> > all the files (TextFilter.java is the one that I happened to notice it
>> > missing from).  Also, is there a reason there's a space before
>> > 'contributor' on the second line of the license blocks?  Looks a bit
>> > weird.
>>
>> Oh, and on a related note, the source tree needs a NOTICE file,
>> something like:
>>
>> http://svn.apache.org/repos/asf/db/derby/code/trunk/NOTICE
> 
> I notice that James has added this in the new tarball, but there's a
> cut-and-paste problem.  The header at the top still mentions Derby, it
> should be changed to Abdera.
> 
> -garrett
> 

Re: Code status

Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 6/12/06, Garrett Rooney <ro...@electricjellyfish.net> wrote:
> On 6/12/06, Garrett Rooney <ro...@electricjellyfish.net> wrote:
> > On 6/12/06, James M Snell <ja...@gmail.com> wrote:
> > > New code drop available:
> > >
> > > http://www.snellspace.com/public/abdera.tar.gz
> > >
> > > Quite a few changes, not the least of which is a change to the new
> > > org.apache.abdera.* package.
> >
> > Great!
> >
> > One thing I noticed is that the ASF license block doesn't appear in
> > all the files (TextFilter.java is the one that I happened to notice it
> > missing from).  Also, is there a reason there's a space before
> > 'contributor' on the second line of the license blocks?  Looks a bit
> > weird.
>
> Oh, and on a related note, the source tree needs a NOTICE file, something like:
>
> http://svn.apache.org/repos/asf/db/derby/code/trunk/NOTICE

I notice that James has added this in the new tarball, but there's a
cut-and-paste problem.  The header at the top still mentions Derby, it
should be changed to Abdera.

-garrett

Re: Code status

Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 6/12/06, Garrett Rooney <ro...@electricjellyfish.net> wrote:
> On 6/12/06, James M Snell <ja...@gmail.com> wrote:
> > New code drop available:
> >
> > http://www.snellspace.com/public/abdera.tar.gz
> >
> > Quite a few changes, not the least of which is a change to the new
> > org.apache.abdera.* package.
>
> Great!
>
> One thing I noticed is that the ASF license block doesn't appear in
> all the files (TextFilter.java is the one that I happened to notice it
> missing from).  Also, is there a reason there's a space before
> 'contributor' on the second line of the license blocks?  Looks a bit
> weird.

Oh, and on a related note, the source tree needs a NOTICE file, something like:

http://svn.apache.org/repos/asf/db/derby/code/trunk/NOTICE

-garrett

Re: Code status

Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 6/12/06, James M Snell <ja...@gmail.com> wrote:
> New code drop available:
>
> http://www.snellspace.com/public/abdera.tar.gz
>
> Quite a few changes, not the least of which is a change to the new
> org.apache.abdera.* package.

Great!

One thing I noticed is that the ASF license block doesn't appear in
all the files (TextFilter.java is the one that I happened to notice it
missing from).  Also, is there a reason there's a space before
'contributor' on the second line of the license blocks?  Looks a bit
weird.

> Also included is the beginnings of a project website.  Please take a
> look and critique.

The site looks good to me, although your disclaimer about the project
being under incubation isn't quite the same as the one the incubator
docs say we should have:

http://incubator.apache.org/incubation/Incubation_Policy.html#Branding

You also might want to work the Incubator Logo into the web site, for
an example of how others have done this see the
http://incubator.apache.org/harmony/ web site.  Using it in place of
the ASF logo you've currently got would look reasonably good.

> The changed content filtering / parse filter optimization code is also
> included.

Nice, thanks for posting a new snapshot.  Hopefully we can get this
into svn soon.

-garrett

Re: Code status

Posted by James M Snell <ja...@gmail.com>.
New code drop available:

http://www.snellspace.com/public/abdera.tar.gz

Quite a few changes, not the least of which is a change to the new
org.apache.abdera.* package.

Also included is the beginnings of a project website.  Please take a
look and critique.

The changed content filtering / parse filter optimization code is also
included.

- James

Garrett Rooney wrote:
> On 6/12/06, James M Snell <ja...@gmail.com> wrote:
>> Both my individual CLA and the code grant have been faxed in.  I'm
>> currently waiting on confirmation for both.  As soon as I get both, I'll
>> check in the current source.  In the meantime, later today I will upload
>> the current snapshot of the source to my personal blog and will post a
>> link here.
> 
> As soon as it shows up I'll let everyone know.  The ASF member's
> meeting is tomorrow, so I suspect our secretary has been a little busy
> getting ready.  If it doesn't end up getting acked in the next day or
> so I'll ask him about it.
> 
> -garrett
> 

Re: Code status

Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 6/12/06, James M Snell <ja...@gmail.com> wrote:
> Both my individual CLA and the code grant have been faxed in.  I'm
> currently waiting on confirmation for both.  As soon as I get both, I'll
> check in the current source.  In the meantime, later today I will upload
> the current snapshot of the source to my personal blog and will post a
> link here.

As soon as it shows up I'll let everyone know.  The ASF member's
meeting is tomorrow, so I suspect our secretary has been a little busy
getting ready.  If it doesn't end up getting acked in the next day or
so I'll ask him about it.

-garrett